Opened 5 years ago

Closed 4 years ago

#15773 closed defect (fixed)

Enable ICU for OS X Tor Browser builds

Reported by: gk Owned by: gk
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: tbb-gitian, TorBrowserTeam201505R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by gk)

We disabled ICU due to cross-compilation issues for 32bit machines in #12812. Now, that we don't ship 32bit OS X packages anymore we can enable it (again).

Child Tickets

Change History (4)

comment:1 Changed 5 years ago by gk

Description: modified (diff)

comment:2 Changed 4 years ago by gk

Keywords: TorBrowserTeam201505R added; TorBrowserTeam201504 removed
Status: newneeds_review

bug_15773 (https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_15773&id=ad3852ac81355033f1630acd43c4e25c043de5f2) has the fix for this bug. I tested it in an OS X build and I think it would even be safe for 4.5 stable. I am fine with putting it only into 5.0a1 though.

comment:3 Changed 4 years ago by mikeperry

Yeah, I am inclined to hold off until 5.0a1 for this.

comment:4 Changed 4 years ago by mikeperry

Resolution: fixed
Status: needs_reviewclosed

Ok, merged into tor-browser-31.7.0esr-5.0-1 for 5.0a1.

Note: See TracTickets for help on using tickets.