Opened 4 years ago

Closed 4 years ago

#15782 closed defect (fixed)

Correct "longest possible policy" comment in router_parse_addr_policy_item_from_string()

Reported by: teor Owned by:
Priority: Very Low Milestone: Tor: 0.2.7.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Keywords: comment-only
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The "longest possible policy" comment in router_parse_addr_policy_item_from_string() used an example policy that was actually shorter than the maximum length.

This comment was amended, and expanded to count the maximum number of
characters.

Comment change only.

Fixed in:
Branch: longest-policy-comment
Repository:https://github.com/teor2345/tor.git

This looks to be a patch on the 2007 code, so who knows what version that was, and is it really that important for a comment?

r15140@catbus: nickm | 2007-09-18 11:34:54 -0400
Get rid of a needless malloc() when parsing address policies. Original patch from "Some guy on #tor", via arma. Altered to have a sufficiently large buffer, and not use the buffer so much, and to save a strlcpy.
svn:r11480

Child Tickets

Change History (2)

comment:1 Changed 4 years ago by teor

Status: newneeds_review

Bugfix on 0.2.0.7-alpha, git commit eee8d750b6a7

comment:2 Changed 4 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged !

Note: See TracTickets for help on using tickets.