Opened 4 years ago

Closed 4 years ago

#15795 closed defect (fixed)

some security slider prefs do not trigger custom checkbox

Reported by: mcs Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: TorBrowserTeam201504R, tbb-4.5-alpha
Cc: brade, gk, mikeperry Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

While working on #15794, Kathy and I noticed that toggling svg.in-content.enabled via about:config does not set the security slider's custom checkbox. We have a fix and will make it available for review in a few minutes.

Child Tickets

Change History (4)

comment:1 Changed 4 years ago by mcs

Keywords: TorBrowserTeam201504R added; TorBrowserTeam201504 removed
Status: newneeds_review

Here is a fix:
https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug15795-01&id=b645cc5cd4a675e6560507e60c83d4bb7aff80d2
Please review. I am not sure if we want to pick this up for 4.5 or not, but it is a pretty safe fix.

comment:2 Changed 4 years ago by mcs

Summary: svg.in-content.enabled does not trigger custom checkboxsome security slider prefs do not trigger custom checkbox

comment:3 Changed 4 years ago by mcs

We found a couple of additional prefs. that were not being monitored. Here is a complete fix:
https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug15795-02&id=cacd8c67be59359b2a9bdf8a2cf2a341401cc77e

comment:4 Changed 4 years ago by gk

Keywords: tbb-4.5-alpha added
Resolution: fixed
Status: needs_reviewclosed

Nice find. Looks good to me. This is commit cacd8c67be59359b2a9bdf8a2cf2a341401cc77e.

Note: See TracTickets for help on using tickets.