details document differences: empty list shown differently

Karsten asked me to open a ticket for this, so I do.

Torprojects instance says: "flags":[] cthulhu's instance says: "flags":[""]

changed milestone to %Onionoo 3.1-1.0.0

added component::metrics/onionoo milestone::Onionoo 3.1-1.0.0 owner::karsten priority::medium resolution::fixed severity::normal status::closed type::defect labels

Branch task-15798 in my public repository contains a possible fix that I'm now testing locally.

Trac:
Owner: N/A to karsten
Status: new to accepted

Local test looks good, pushing slightly tweaked version to task-15798-2 in my public repository and deploying on thecthulhu.com. It may take a week until all current details files are updated. Let's revisit in a week and see if there are any "flags":[""] left on thecthulhu.com. Note that torproject.org also had those in some cases. If this succeeds, I'll also deploy this branch on torproject.org and resolve this ticket.

Also consider updating the documentation, which says:

"Omitted if empty."

The fix seems fine and should be part of the first release.

Trac:
Milestone: N/A to Onionoo 3.1-1.0.0
Sponsor: N/A to N/A
Status: accepted to merge_ready
Severity: N/A to Normal
Reviewer: N/A to N/A

Replying to iwakeh:

The fix seems fine and should be part of the first release.

Agreed, pushed to master.

Also updated the documentation to say "May be omitted if empty." I checked current details files and didn't find a single entry with empty or omitted flags list.

Closing. Thanks!

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

closed