Opened 4 years ago

Closed 3 years ago

#15798 closed defect (fixed)

details document differences: empty list shown differently

Reported by: cypherpunks Owned by: karsten
Priority: Medium Milestone: Onionoo 3.1-1.0.0
Component: Metrics/Onionoo Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Karsten asked me to open a ticket for this, so I do.

Torprojects instance says:
"flags":[]
cthulhu's instance says:
"flags":[""]

Child Tickets

Change History (5)

comment:1 Changed 4 years ago by karsten

Owner: set to karsten
Status: newaccepted

Branch task-15798 in my public repository contains a possible fix that I'm now testing locally.

comment:2 Changed 4 years ago by karsten

Local test looks good, pushing slightly tweaked version to task-15798-2 in my public repository and deploying on thecthulhu.com. It may take a week until all current details files are updated. Let's revisit in a week and see if there are any "flags":[""] left on thecthulhu.com. Note that torproject.org also had those in some cases. If this succeeds, I'll also deploy this branch on torproject.org and resolve this ticket.

comment:3 Changed 4 years ago by cypherpunks

Also consider updating the documentation, which says:

"Omitted if empty."

comment:4 Changed 3 years ago by iwakeh

Milestone: Onionoo 3.1-1.0.0
Severity: Normal
Status: acceptedmerge_ready

The fix seems fine and should be part of the first release.

comment:5 in reply to:  4 Changed 3 years ago by karsten

Resolution: fixed
Status: merge_readyclosed

Replying to iwakeh:

The fix seems fine and should be part of the first release.

Agreed, pushed to master.

Also updated the documentation to say "May be omitted if empty." I checked current details files and didn't find a single entry with empty or omitted flags list.

Closing. Thanks!

Note: See TracTickets for help on using tickets.