Silly ambiguous function names in rendservices
rendservices.c has two functions:
rend_services_introduce rend_service_introduce
One of these is called every second to consider adding new intro points to our services. The other one is called to handle an inbound INTRODUCE2 cell for a service.
I suggest renaming them to something like:
rend_consider_services_intro_points rend_service_receive_introduction
Also worth noting that rend_service_validate_intro_early does nothing (/* TODO */).