Opened 4 years ago

Last modified 3 years ago

#15842 assigned defect

Refactor and upstream patch for #10280

Reported by: cypherpunks Owned by: gk
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201608
Cc: gk, arthuredelstein Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Mozilla's team reviewed and discussed our patch for #10280.
https://bugzilla.mozilla.org/show_bug.cgi?id=817255#c20

First, after new GMP (https://wiki.mozilla.org/GeckoMediaPlugins), patch with ESR-38 could be wrong/invalid/incomplete/broken.

Second, they don't want new UI elements for about:addons (Plugins). Do we need this UI elements? Isn't Torbutton's menu (Security settings) should be enough to allow or disallow plugins?
Our FAQ https://www.torproject.org/docs/faq.html.en#TBBFlash says nothing about steps to allow Flash neither?

In general, we could to simplify patch a lot using all comments from review, or discuss about race conditions that simplify could lead to.

Child Tickets

Attachments (1)

DisablePlugins.png (4.8 KB) - added by bugzilla 3 years ago.

Download all attachments as: .zip

Change History (16)

comment:1 Changed 4 years ago by gk

Cc: gk added

comment:2 Changed 4 years ago by mikeperry

Keywords: tbb-5.0a-highrisk added

Tag the set of things that are risky to debut in the 5.0-stable release without testing in a prior alpha.

comment:3 Changed 4 years ago by mikeperry

Keywords: TorBrowserTeam201506 added

Ensure all tbb-5.0a items are on the June radar.

comment:4 Changed 4 years ago by mikeperry

Keywords: MikePerry201506 added
Owner: changed from tbb-team to mikeperry
Status: newassigned

comment:5 Changed 4 years ago by mikeperry

Keywords: GeorgKoppen201506 added; MikePerry201506 removed
Owner: changed from mikeperry to gk

comment:6 Changed 4 years ago by gk

Keywords: ff45-esr added; ff38-esr tbb-5.0a-highrisk removed

We don't need to do the refactoring for ESR 38. GMPs are disabled and not downlaoded (they can't even be donwloaded in the EME case at all as there are no such plugins for OS X and Linux and the original download URL is not working as we are using mingw-w64). Given that these plugins' scope is not system-wide one must try quite hard to get them loaded into the process space at all. We can ignore this case for now. We should try to get Mozilla's requested changes merged upstream in the window for Firefox 45 although Mozilla's different treatment of GMPs does not make the patch unnecessary for us...

comment:7 Changed 4 years ago by mikeperry

Keywords: TorBrowserTeam201506 removed

comment:8 Changed 3 years ago by gk

Keywords: TorBrowserTeam201605 added

Dragging into May to have it on our 6.0 radar.

comment:9 Changed 3 years ago by gk

Keywords: ff45-esr GeorgKoppen201506 removed
Severity: Normal

No specific esr45 item (anymore).

comment:10 Changed 3 years ago by gk

Cc: arthuredelstein added
Summary: Refactor #10280 patch for ESR-38Refactor and upstream patch for #10280

comment:11 Changed 3 years ago by gk

Keywords: TorBrowserTeam201606 added; TorBrowserTeam201605 removed

comment:12 Changed 3 years ago by gk

Keywords: TorBrowserTeam201607 added; TorBrowserTeam201606 removed

comment:13 Changed 3 years ago by gk

Keywords: TorBrowserTeam201608 added; TorBrowserTeam201607 removed

Moving items to August 2016.

Changed 3 years ago by bugzilla

Attachment: DisablePlugins.png added

comment:14 Changed 3 years ago by bugzilla


Hint of the button is confusing - why only system plugins?
Clicking on the button leads to false sense of security, because no plugins are disabled, and it's not synchronized with Torbutton (Disable browser plugins is still unchecked).

comment:15 Changed 3 years ago by bugzilla

Note: See TracTickets for help on using tickets.