Opened 5 years ago

Closed 5 years ago

#15850 closed defect (fixed)

Don't assign HSDir flag to relay that can't handle BEGIN_DIR

Reported by: dgoulet Owned by:
Priority: High Milestone: Tor: 0.2.7.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: 026-backport
Cc: Actual Points:
Parent ID: #15801 Points: small
Reviewer: Sponsor:

Description

Child ticket of #15801.

Because of #14202 (introduced in 0.2.6), directory authorities can assign the HSDir flag to a relay without a DirPort but relay can't handle BEGIN_DIR cell if they don't have the DirPort set (see #15849).

Commit 80bed1ac96a3035f8c55ddced5528f0d7d16d386 should be reverted and backported. Right now, we have 8 directory authorities that are >= 0.2.6 so we should backport this fix asap to 026.

Child Tickets

Change History (3)

comment:1 Changed 5 years ago by dgoulet

Status: newneeds_review

Attempt at a fix: bug15850_026_01. Based on 026 because the fix must be backported up to that version.

Also, I have to emphasis this, dir. auth. will need to update ASAP because until then we have one third of HSDir that are not working.

comment:2 Changed 5 years ago by nickm

Have merged to 0.2.6 and forward.

comment:3 Changed 5 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed
Note: See TracTickets for help on using tickets.