Opened 5 years ago

Closed 5 years ago

#15915 closed defect (fixed)

Circuit display is shown when display_circuit is disabled since Tor Browser start

Reported by: anonym Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: AffectsTails, tbb-circuit-display, tbb-torbutton
Cc: arthuredelstein Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

If extensions.torbutton.display_circuit = false when starting Tor Browser 4.5 with Torbutton 1.9.2.2, then the circuit display will be enabled, showing an example circuit (A, B, C) which is confusing and (I believe) unintended.

That pref is bound to the start() and stop() functions defined in setupDisplay() (in src/chrome/content/tor-circuit-display.js). When the pref is false we'll call stop(), which will call syncDisplayWithSelectedTab(false) (which disables the display) but it is only called *if* myController is set. However, myController is *not* set if this pref was false since Tor Browser start so we should move syncDisplayWithSelectedTab(false) outside of that if statement.

Here's a patch. Since we in Tails has disabled the circuit view for now, we'd greatly appreciate if this could be fixed in the expected Tor Browser release (4.5.1?) on 2015-05-12, so this will be fixed in Tails 1.4 released on the same day.

Child Tickets

Attachments (1)

0001-Hide-circuit-display-if-pref-was-disabled-from-start.patch (1.1 KB) - added by anonym 5 years ago.

Download all attachments as: .zip

Change History (3)

comment:1 Changed 5 years ago by gk

Cc: arthuredelstein added
Component: TorbuttonTor Browser
Keywords: tbb-circuit-display tbb-torbutton added
Owner: set to tbb-team

Good catch. Looks good to me and is now commit fc05d63ab7f01fabf999960d31a9795349054a7b on torbutton master (I just slightly adapted the commit message).

comment:2 Changed 5 years ago by gk

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.