Opened 4 years ago

Closed 4 years ago

#15921 closed defect (fixed)

unused-but-set-variable (proxyHost and proxyPort) build errors on Mozilla Try

Reported by: boklm Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: TorBrowserTeam201505R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When pushing tor-browser-31.6.0esr-4.5-1 to Mozilla Try, the build fails with the following error:

    /builds/slave/try-lx-d-000000000000000000000/build/src/netwerk/base/src/nsSocketTransport2.cpp:1083:21: error: variable 'proxyHost' set but not used [-Werror=unused-but-set-variable]
    /builds/slave/try-lx-d-000000000000000000000/build/src/netwerk/base/src/nsSocketTransport2.cpp:1084:17: error: variable 'proxyPort' set but not used [-Werror=unused-but-set-variable] 

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f828bf8f28dd

I am attaching a patch to fix the issue.

Child Tickets

Attachments (1)

0001-fixup-Bug-3455.2.-Allow-RFC1929-authentication-usern.patch (1.5 KB) - added by boklm 4 years ago.

Download all attachments as: .zip

Change History (3)

comment:1 Changed 4 years ago by boklm

Status: newneeds_review

comment:2 Changed 4 years ago by mikeperry

Resolution: fixed
Status: needs_reviewclosed

This looks OK to me. I don't see any use or side effects from removing these lines. Merged for 4.5.1. Thanks, boklm!

Note: See TracTickets for help on using tickets.