Opened 4 years ago

Closed 4 years ago

#15922 closed defect (fixed)

-Werror=reorder build error on Mozilla Try

Reported by: boklm Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: TorBrowserTeam201505R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


When pushing tor-browser-31.6.0esr-4.5-1 to Mozilla Try, after fixing #15921, the build fails with the following error:

    ../../../dist/include/mozilla/net/HttpBaseChannel.h:339:11: error: 'mozilla::net::HttpBaseChannel::mRedirectCount' will be initialized after [-Werror=reorder]
    ../../../dist/include/mozilla/net/HttpBaseChannel.h:327:20: error: 'nsCOMPtr<nsIURI> mozilla::net::HttpBaseChannel::mProxyURI' [-Werror=reorder]
    /builds/slave/try-lx-d-000000000000000000000/build/src/netwerk/protocol/http/HttpBaseChannel.cpp:39:1: error: when initialized here [-Werror=reorder]

I am attaching a patch to fix the issue.

Child Tickets

Attachments (1)

0001-fixup-Bug-3455.1-Allow-proxy-settings-to-be-set-per-.patch (1.4 KB) - added by boklm 4 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 4 years ago by boklm

Status: newneeds_review

comment:2 Changed 4 years ago by mcs

The fix looks good.

comment:3 Changed 4 years ago by mikeperry

Resolution: fixed
Status: needs_reviewclosed

Ok, merged for 4.5.1.

Note: See TracTickets for help on using tickets.