Opened 5 years ago

Closed 5 years ago

#15927 closed defect (fixed)

NoScript UI doesn't update upon security slider change

Reported by: mikeperry Owned by: mikeperry
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: tbb-usability, TorBrowserTeam201505R, GeorgKoppen201505R
Cc: gk Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

People on the blog have been reporting that the NoScript UI isn't updating when the security slider position is changed. This is causing them to wonder if scripts weren't really enabled/disabled by their security slider change.

Child Tickets

Change History (4)

comment:1 Changed 5 years ago by mikeperry

Status: newneeds_review

Patch for review in https://gitweb.torproject.org/mikeperry/torbutton.git/commit/?h=bug15927.

May be a bit fragile because it depends on a semi-private NoScript overlay function, but it solves the problem. I had to resort to this after the official NoScript observer topic "noscript:sync-ui" did not work.

comment:2 Changed 5 years ago by mikeperry

The commit hash of that branch should be 6e787bddb0798f6d47eb27e5f0bb26610ac2bff4. (I pushed a forced update because an earlier version only reset the NoScript UI for the current window -- we need to reset all windows).

comment:3 Changed 5 years ago by gk

Cc: gk added
Keywords: GeorgKoppen201505R added

comment:4 Changed 5 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good to me, thanks. I shortened the commit message a bit as we are forcing a NoScript UI update even if the security slider level does not change. As long as the user presses "OK" on the slider dialog your code is running. Commit fecc621d6c3928918b4c62071f41ac2e4287e121 has the changes.

Note: See TracTickets for help on using tickets.