Changes between Initial Version and Version 1 of Ticket #16010, comment 63


Ignore:
Timestamp:
Sep 22, 2017, 1:22:07 AM (20 months ago)
Author:
arthuredelstein
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #16010, comment 63

    initial v1  
    44> Attached is a fix for the `tor-browser-build` site as well as this is still needed due to different `.mozconfig` handlings.
    55
    6 I also had a look and didn't find any obvious errors, though I too am not familiar with the problems. I think it might be useful to briefly document the compile issues fixed in the first patch, either as comments or in the commit message.
     6I also had a look and didn't find any obvious errors, though I too am not familiar with the chromium sandbox code. I think it might be useful to briefly document the compile issues fixed in the first patch, either as comments or in the commit message.
    77
    88One thing that puzzled me is the section here:
    99https://gitweb.torproject.org/user/gk/tor-browser.git/diff/security/sandbox/chromium-shim/base/win/sdkdecls.h?h=bug_16010_v4&id=4f613829fdcbf6dba4e80e8df1d356cb1c0a7de7
    10 You have changed one constant integer to the uLL suffix, but the others remain ui64. I'm wondering it there's a reason for that.
     10You have changed one constant integer to the uLL suffix, but the others remain ui64. I'm wondering if there's a reason for that.