Opened 4 years ago

Last modified 20 months ago

#16016 new defect

extrainfo_insert(): Bug: No entry found in extrainfo map.

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-relay extrainfo warning annoying
Cc: Actual Points:
Parent ID: Points: medium
Reviewer: Sponsor:

Description

I get these on moria1 pretty often. It's been ongoing for a long time I think -- since whenever we attempted to fix that last bug with ri / ei synchronization.

Here's a potentially useful info-level log:

May 13 18:50:37.600 [info] connection_dir_client_reached_eof(): Received extra server info (size 5307) from server '131.188.40.189:80'
May 13 18:50:37.600 [info] router_load_extrainfo_from_string(): 3 elements to add
May 13 18:50:37.600 [warn] extrainfo_insert(): Bug: No entry found in extrainfo map. [1 similar message(s) suppressed in last 1800 seconds] (on Tor 0.2.7.1-alpha-dev 95a9920461dd3322)
May 13 18:50:37.623 [info] connection_dir_client_reached_eof(): Received 0/9 extra-info documents requested from 131.188.40.189:80

I don't know if this last line is related or not.

Actually, I get one of the Bug: messages every hour on moria1, a little bit after the 50 minute mark. Sounds like I'm hearing votes from other authorities, and they make me think of an extrainfo I don't have, so I try to get it, and then bug.

Child Tickets

Change History (21)

comment:1 Changed 4 years ago by toralf

I get this warning after I added

# the following is derived from https://stem.torproject.org/tutorials/mirror_mirror_on_the_wall.html
#
FetchDirInfoEarly 1
FetchDirInfoExtraEarly 1
FetchUselessDescriptors 1
UseMicrodescriptors 0
DownloadExtraInfo 1

to torrc and restartet tor yesterday (0.2.6.9)
For completeness however openssl was upgraded from 1.0.1n to 1.0.1o.

comment:2 Changed 4 years ago by nickm

Keywords: PostFreeze027 added

I'd merge patches for these for 0.2.7 if they come in on time. In some cases, that will require figuring out an as-yet-unsolved bugs.

comment:3 Changed 4 years ago by nickm

Priority: normalmajor

comment:4 Changed 4 years ago by nickm

Keywords: 027-backport added
Milestone: Tor: 0.2.7.x-finalTor: 0.2.8.x-final

comment:5 Changed 4 years ago by nickm

Priority: HighMedium

comment:6 Changed 4 years ago by nickm

Milestone: Tor: 0.2.8.x-finalTor: 0.2.9.x-final

It is impossible that we will fix all 226 currently open 028 tickets before 028 releases. Time to move some out. This is my second pass through the "new" and tickets, looking for things to move to 0.2.9.

comment:7 Changed 3 years ago by nickm

Points: medium
Severity: Normal

comment:8 Changed 3 years ago by isabela

Milestone: Tor: 0.2.9.x-finalTor: 0.2.???

tickets market to be removed from milestone 029

comment:9 Changed 3 years ago by Sebastian

As a data point, this is still happening on gabelmoo:

Jun 22 09:59:14.000 [warn] extrainfo_insert(): Bug: No entry found in extrainfo map. [361 similar message(s) suppressed in last 1800 seconds] (on Tor 0.2.7.6 )

Note how many similar messages are being suppressed.

comment:10 in reply to:  9 Changed 3 years ago by teor

Replying to Sebastian:

As a data point, this is still happening on gabelmoo:

Jun 22 09:59:14.000 [warn] extrainfo_insert(): Bug: No entry found in extrainfo map. [361 similar message(s) suppressed in last 1800 seconds] (on Tor 0.2.7.6 )

Note how many similar messages are being suppressed.

Did we fix this in #17150, which was merged to 0.2.8.3-alpha?
It seems to be a similar issue, but I'm not sure if they are identical.

comment:11 Changed 3 years ago by arma

moria1 gets these messages too:

Jun 22 07:08:56.447 [warn] extrainfo_insert(): Bug: No entry found in extrainfo map. [174 similar message(s) suppressed in last 1800 seconds] (on Tor 0.2.9.0-alpha-dev 33ffeab69417d2db)
Jun 22 07:42:56.281 [warn] extrainfo_insert(): Bug: No entry found in extrainfo map. [104 similar message(s) suppressed in last 1800 seconds] (on Tor 0.2.9.0-alpha-dev 33ffeab69417d2db)

so I'm going to go with "no, not fixed in 0.2.8.3-alpha".

Last edited 3 years ago by arma (previous) (diff)

comment:12 Changed 3 years ago by arma

Aug 05 10:25:00.410 [info] router_load_extrainfo_from_string(): 13661 elements to add
Aug 05 10:25:00.410 [info] extrainfo_insert(): Bug: No entry found in extrainfo map. (on Tor 0.2.9.1-alpha c9b8d4c086931d80)
Aug 05 10:25:00.474 [info] router_load_extrainfo_from_string(): 250 elements to add

bug remains in 0.2.9.1-alpha.

comment:13 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:14 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:15 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:16 Changed 2 years ago by nickm

Keywords: 027-backport removed

These are not ripe for an 027 backport

comment:17 Changed 2 years ago by nickm

Keywords: PostFreeze027 removed

comment:18 Changed 2 years ago by nickm

Keywords: tor-relay extrainfo warning annoying added

comment:19 Changed 2 years ago by arma

I still get these every hour, sometimes many times an hour:

Jun 20 12:06:13.227 [warn] extrainfo_insert(): Bug: No entry found in extrainfo map. [37 similar message(s) suppressed in last 1800 seconds] (on Tor 0.3.0.7-dev 638e97249d2a3a7d)

comment:20 Changed 20 months ago by Sebastian

I just got this on a relay where I enabled DownloadExtraInfo and then reloaded

comment:21 Changed 20 months ago by teor

This might be related to commit a21381a in 0.2.0.3-alpha, where we disabled the desc_by_eid_map check in routerlist_assert_ok(). If we fix this bug, we should re-enable it with a non-fatal assert.

    /* XXXX
     *
     *   Hoo boy.  We need to fix this one, and the fix is a bit tricky, so
     * commenting this out is just a band-aid.
     *
     *   The problem is that, although well-behaved router descriptors
     * should never have the same value for their extra_info_digest, it's
     * possible for ill-behaved routers to claim whatever they like there.
     *
     *   The real answer is to trash desc_by_eid_map and instead have
     * something that indicates for a given extra-info digest we want,
     * what its download status is.  We'll do that as a part of routerlist
     * refactoring once consensus directories are in.  For now,
     * this rep violation is probably harmless: an adversary can make us
     * reset our retry count for an extrainfo, but that's not the end
     * of the world.  Changing the representation in 0.2.0.x would just
     * destabilize the codebase.
    if (!tor_digest_is_zero(r->cache_info.extra_info_digest)) {
      signed_descriptor_t *sd3 =
        sdmap_get(rl->desc_by_eid_map, r->cache_info.extra_info_digest);
      tor_assert(sd3 == &(r->cache_info));
    }
    */
Note: See TracTickets for help on using tickets.