Opened 4 years ago

Closed 4 years ago

#16033 closed defect (fixed)

Silence some make rules

Reported by: cypherpunks Owned by:
Priority: Very Low Milestone: Tor: 0.2.7.x-final
Component: Core Tor/Tor Version: Tor: 0.2.7
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The make rules for generating the file micro-revision.i and changing the permissions of the test scripts are IMO not configured correctly.

The micro-revision generation rule runs on every call to make. Its function requires it to stay up-to-date to the current state of the repository. My question is whether the act of updating/generating the file needs to be communicated back to the user every time? IMO it clutters the terminal (especially on make check where the focus should be on the test results not on output of irrelevant make rules).

Changing the permissions of the test scripts should be silent IMO unless silent rules are disabled. It clutters up the terminal when running make check.

Child Tickets

Attachments (1)

0001-Silence-two-make-rules.patch (1.1 KB) - added by cypherpunks 4 years ago.
Patch for silencing the aforementioned make rules unless silent rules are disabled

Download all attachments as: .zip

Change History (4)

Changed 4 years ago by cypherpunks

Patch for silencing the aforementioned make rules unless silent rules are disabled

comment:1 Changed 4 years ago by nickm

Milestone: Tor: 0.2.7.x-final
Status: newneeds_review

comment:2 Changed 4 years ago by nickm

lgtm; will merge once git SSH access is back.

comment:3 Changed 4 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merging. Sorry for delay. Thanks!

Note: See TracTickets for help on using tickets.