Opened 4 years ago

Closed 4 years ago

#16118 closed defect (worksforme)

error "Error: Error extracting /path/to/source-root/tools/update-responses/../../../gitian-builder/inputs/mar-tools-linux64.zip" in gitian parallel make

Reported by: krichter Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: tbb-gitian
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When I build 7c759425b65eb7a2e7b42564d65f3cd784cc9ab5 in gitian with env MAKEFLAGS='-jN' make TORSOCKS= I can trigger the error by setting N in MAKEFLAGS to 1 (doesn't occur) or to 16 (didn't try other values).

The relevant part of the make output:

rm -f ../../gitian-builder/inputs/bundle-*
./check-prerequisites.sh
./mkbundle-linux.sh
../tools/update-responses/download_missing_versions release
./hash-bundles.sh versions
rm -f ../../gitian-builder/inputs/*utils.zip
rm -f ../../gitian-builder/inputs/tor-linux*
rm -f ../../gitian-builder/inputs/tor-browser-linux*
rm -f ../../gitian-builder/inputs/pluggable-transports*
rm -f ../../gitian-builder/inputs/tor-mac*
rm -f ../../gitian-builder/inputs/tor-browser-mac*
rm -f ../../gitian-builder/inputs/tor-win*
rm -f ../../gitian-builder/inputs/tor-browser-win*
rm -f ../../gitian-builder/inputs/mar-tools-*
rm -f ../../gitian-builder/inputs/*.yml
rm -f ../../gitian-builder/inputs/bundle.inputs
rm -f ../../gitian-builder/inputs/versions*
./fetch-inputs.sh ../../gitian-builder/inputs/ versions
Error: Error extracting /mnt/richtercloud/sources/tor-browser-bundle/tools/update-responses/../../../gitian-builder/inputs/mar-tools-linux64.zip
make: *** [incrementals] Error 1
make: *** Waiting for unfinished jobs....
--2015-05-19 18:24:30--  https://www.openssl.org/source/openssl-1.0.1m.tar.gz
Resolving www.openssl.org (www.openssl.org)... 194.97.150.234
Connecting to www.openssl.org (www.openssl.org)|194.97.150.234|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 4533406 (4.3M) [application/x-gzip]
Server file no newer than local file ‘openssl-1.0.1m.tar.gz’ -- not retrieving.

Child Tickets

Change History (5)

comment:1 Changed 4 years ago by gk

Keywords: tbb-gitian added
Status: newneeds_information

I am a bit confused by the parts of your log. What exactly did you invoke to get it? The think is if you delete all the mar-tools-* then it is obvious why the mar-tools-linux64.zip is missing later on.

comment:2 Changed 4 years ago by krichter

I didn't do anything than the mentioned command (make) and didn't do any manipulations of the source root. I think the issue occurs because make 3.81 executes the script multiple times where the second invokation fails because the file is already deleted. Might be a make bug.

comment:3 Changed 4 years ago by gk

What happens if you omit MAKEFLAGS and use the NUM_PROCS environment variable instead (see: https://gitweb.torproject.org/builders/tor-browser-bundle.git/tree/gitian/README.build#n33ff for an explanation)?

comment:4 Changed 4 years ago by krichter

It works fine and the build in the VM works well in parallel. Nevertheless, if the Makefile turns out to fail with -j[>1], then some feedback has to be given or make needs to fail.

Last edited 4 years ago by krichter (previous) (diff)

comment:5 Changed 4 years ago by gk

Resolution: worksforme
Status: needs_informationclosed

I think this is working fine as it is right now. However, I would not mind taking a patch to fix this problem. Feel free to reopen this ticket in this case.

krichter: Do you have by chance the need information to investigate #16124 further?

Note: See TracTickets for help on using tickets.