Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#1612 closed task (implemented)

Group reserved bridges into buckets for people

Reported by: phobos Owned by: kaner
Priority: Medium Milestone:
Component: Circumvention/BridgeDB Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: #4380 Points:
Reviewer: Sponsor:

Description (last modified by arma)

Group reserved bridges into buckets for people, write those buckets to files on request. (So that those files can be used by Roger or $foo to give to trusted people)

Child Tickets

Change History (8)

comment:1 Changed 9 years ago by phobos

Component: Tor - DistributionTor - BridgeDB

comment:2 Changed 9 years ago by kaner

Owner: set to kaner
Status: newassigned

comment:3 Changed 9 years ago by kaner

Status: assignedneeds_review

comment:4 Changed 9 years ago by nickm

Status: needs_reviewassigned

Summarizing issues from IRC:

  • f.close doesn't close a file; you need to use f.close()
  • Suggestion to prefix names of pseudodistributors with pseudo: in the database to easily tell them apart from real ones without needing an exhaustive list of real distributors
  • Try pylint and pychecker
  • Tests would be good
  • next time you want to move a bunch of code and change it too, please do one patch that only moves the code, so it's easier to see what changed.
  • isBucketIdentKnown should return a bool, or should be renamed to getBucketByIdent or something


comment:5 Changed 9 years ago by arma

Description: modified (diff)
Summary: Group unreserved bridges into buckets for peopleGroup reserved bridges into buckets for people

comment:6 Changed 9 years ago by kaner

Status: assignedneeds_review

Changed the code according to Nick's comments, please review again and/or merge as you see fit: https://gitweb.torproject.org/kaner/bridgedb.git/shortlog/refs/heads/bug_1612

TIA

comment:7 Changed 9 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

merged & closing.

comment:8 Changed 8 years ago by karsten

Milestone: BridgeDB Upgrades Phase 1
Parent ID: #4380

Assigning as a child ticket to the project ticket that replaces the "BridgeDB Upgrades Phase 1" milestone.

Note: See TracTickets for help on using tickets.