Opened 4 years ago

Closed 4 years ago

#16150 closed defect (fixed)

ESR 38 contains filenames with spaces which breaks our Gitian builds

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: tbb-gitian, ff38-esr, TorBrowserTeam201506R, tbb-5.0a3-essential
Cc: mcs Actual Points:
Parent ID: #15772 Points:
Reviewer: Sponsor:

Description

find -type f | xargs touch --date="$REFERENCE_DATETIME" is broken if we have files with spaces in their filenames.

Child Tickets

Change History (9)

comment:1 Changed 4 years ago by mcs

Cc: mcs added

We should be able to fix this by using null seperators (although I have not tried it), e.g.,

find -type f -print0 | xargs -0 touch --date="$REFERENCE_DATETIME"

comment:2 Changed 4 years ago by gk

Keywords: TorBrowserTeam201505R added
Status: newneeds_review

comment:3 Changed 4 years ago by mcs

Your changes look good to me.

Do you happen to know which files in ESR 38 have spaces? We have not noticed a problem with the updater yet, although previously Mozilla's MAR file generation scripts had problems handling paths that contained spaces (Kathy and I tried to fix those problems when we made the original updater changes for TB, just in case).

comment:4 Changed 4 years ago by gk

browser/components/migration/tests/unit/Library/Application%20Support/ caused this ticket. I have not checked systematically whether there are more instances in the tree now.

comment:5 Changed 4 years ago by mcs

For the record, running a find command on an esr38 tree reveals the following (all part of various tests):

./browser/components/migration/tests/unit/Library/Application Support
./browser/components/migration/tests/unit/Library/Application Support/Google/Chrome/Local State
./layout/reftests/fonts/sil/Scheherazade-R 2012-07-03c.ttf
./media/webrtc/trunk/tools/gyp/test/win/command-quote/bat with spaces.bat

comment:6 Changed 4 years ago by mikeperry

Keywords: TorBrowserTeam201506 added

comment:7 Changed 4 years ago by mikeperry

Keywords: TorBrowserTeam201506R added; TorBrowserTeam201505R TorBrowserTeam201506 removed

comment:8 Changed 4 years ago by mikeperry

Keywords: tbb-5.0a3-essential added

Tag the set of things we should aim to understand/fix for the fist FF38-based TBB (5.0a3, on June 30th).

comment:9 Changed 4 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

This is merged into master with commit f1783ba6746b9facbd35273d665cd48a36eb9c2f.

Note: See TracTickets for help on using tickets.