Opened 5 years ago

Closed 5 years ago

#16153 closed defect (fixed)

[warn] tor_tls_client_is_using_v2_ciphers(): Bug: Whoops. session->ciphers doesn't match SSL_get_ciphers() (on Tor 0.2.7.1-alpha-dev 45a9057 3e69d12dc)

Reported by: arma Owned by:
Priority: High Milestone: Tor: 0.2.7.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-relay tls openssl
Cc: yawning Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

[warn] tor_tls_client_is_using_v2_ciphers(): Bug: Whoops. session->ciphers doesn't match SSL_get_ciphers() (on Tor 0.2.7.1-alpha-dev 45a90573e69d12dc)

This is moria1, running on RHEL. Presumably it's related to some of the recent openssl changes.

Child Tickets

Change History (9)

comment:1 Changed 5 years ago by arma

Oh, and I should also clarify that it happens a *lot*. I moved away from git master since my logs are just packed with these lines.

comment:2 Changed 5 years ago by yawning

Keywords: tor-relay tls added

comment:3 Changed 5 years ago by nickm

Cc: yawning added
Priority: normalmajor

Ugh. This implies a problem with one of our approaches.

If the ciphers in the session don't match the ones on the ssl object, then we probably can't use SSL_get_ciphers() as a proxy for them.

Yawning, any ideas?

comment:4 Changed 5 years ago by nickm

Keywords: openssl added

Ugh. This implies a problem with one of our approaches.

If the ciphers in the session don't match the ones on the ssl object, then we probably can't use SSL_get_ciphers() as a proxy for them.

Yawning, any ideas?

comment:5 Changed 5 years ago by yawning

Not off the top of my head, I'll poke at it when I get back to my fortress of solitude, only saw the ticket while on the train, and didn't have much time to think about it when I got to my destination. :/

comment:6 Changed 5 years ago by nickm

Okay, we need to revert either 67964cfa787461bc56380fe46439fd5c9863bb4f, or 2f7c9b6ecb1a7855167b2c65781b2c4b1b014807, or both.

comment:7 Changed 5 years ago by nickm

Actually, I'm pretty sure we should revert the first of those, but not sure about the second.

comment:8 Changed 5 years ago by nickm

c8024b633eeff6161292666b209b538fda9df4ab reverts 67964cfa787461bc56380fe46439fd5c9863bb4f ; I think that should be enough.

comment:9 Changed 5 years ago by nickm

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.