Generating the MAR tools is broken due to missing certutil with ESR 38

+ cp -p 'obj-*/security/nss/cmd/certutil/certutil' /home/ubuntu/build/mar-tools/
cp: cannot stat `obj-*/security/nss/cmd/certutil/certutil': No such file or directory

Looking around certutil does not seem to get built at all any longer with our current .mozconfig.

added component::applications/tor browser ff38-esr owner::gk parent::15772 priority::medium resolution::fixed status::closed tbb-gitian type::defect labels

mcs, brade: it seems you forgot that bit while backporting your MAR signing patch, no?

Trac:
Cc: N/A to mcs, brade

Replying to gk:

mcs, brade: it seems you forgot that bit while backporting your MAR signing patch, no?

Yes, a portion of the MAR signing patch was lost. We will figure out why and provide the missing piece. Sorry about that!

Trac:
0001-fixup-Bug-13379-Sign-our-MAR-files.patch

fixup! patch (always build certutil)

I attached a fixup patch (I am not sure where it needs to be committed; maybe to Arthur's repo for now?)

This portion of the #13379 (moved) patch got dropped accidentally because Mozilla moved the Makefile.in that it applies to. Unfortunately, Kathy and I used a combination of format-patch / git am to rebase our patches for ESR 38, and today we learned that although git am complained that "error: security/build/Makefile.in: does not exist in index" we did not notice that message among the other noise. We will go double-check our other patches now.

Trac:
Cc: mcs, brade to mcs, brade, arthuredelstein
Status: new to needs_review

Replying to mcs:

I attached a fixup patch (I am not sure where it needs to be committed; maybe to Arthur's repo for now?)

The patch looks good. I've been building with that one earlier today and it is working.

I've added the patch to the rebasing branch here: https://github.com/arthuredelstein/tor-browser/commits/tb_GECKO380esr_2015050513_RELBRANCH

Calling this fixed, then.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

moved to tpo/applications/tor-browser#16196 (closed)