Opened 2 years ago

Closed 21 months ago

#16227 closed defect (fixed)

Document which descriptor lines can have extra fields.

Reported by: atagar Owned by:
Priority: Medium Milestone: Tor: 0.2.8.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 028-triage
Cc: isis Actual Points:
Parent ID: Points: small/medium
Reviewer: Sponsor:

Description

Hi, DocTor checks just notified me of an invalid extrainfo descriptor from a tor relay running Tor 0.2.7.1-alpha-dev...

router Truie 198.50.156.78 9001 0 9030
identity-ed25519
-----BEGIN ED25519 CERT-----
AQQABhWIAZTz0r0KRagr6X9SHfm4oiIuMLVhJQQmNchtkBuR5SuFAQAgBAAVkw7m
0YJgO/A8VMioco097sIOutDiM7UqqPvoIyKErk1akOm3f6VAO/juOzxEeAgzgfA7
DiRsSjeVjp0xUdE43bXhK/8Uh+SPMwYKj47drjgTHGgzjTmlY9B/jFJ1Wgs=
-----END ED25519 CERT-----
platform Tor 0.2.7.1-alpha-dev on Linux
protocols Link 1 2 Circuit 1
published 2015-05-28 15:44:47
fingerprint A692 21A7 EC74 98D2 F88A 0FB7 9526 1013 FA36 CAAE
uptime 61
bandwidth 1073741824 1073741824 9506816
extra-info-digest 0879DB7B765218D7B3AE7557669D20307BB21CAA V609l+N6ActBveebfNbH5lQ6wHDNstDkFgyqEhBHwtA
onion-key
-----BEGIN RSA PUBLIC KEY-----
MIGJAoGBALbTpnPvhaGET+2ACtLdG6jhQXN8uVJ0iF9RwMh2hwu351yp3eVPt7os
ditUF6w7KV+6emkvLu9EBpNN7vWrpDAhRNOGTOZhZKLnGFaxp+eGNX6+5AhmiWYt
/+w+f6dvVKEjsaX3XZsMqcTBjw2hzVpHxh/AjgDx/b9mJKC85vENAgMBAAE=
-----END RSA PUBLIC KEY-----
signing-key
-----BEGIN RSA PUBLIC KEY-----
MIGJAoGBALDSt2G+Zjl20a59HZsuag913ONdnnNa/uVMRbsZZkbnNRONf2aXBGgu
wrW7XtPLeAKl+d0d5g9XnePVvefcEdKvoKNCFv6s8s3S2KB/CEkeyE7Lxx1Pc6Qx
f/jgS3T3TFHUlvtZvHLZ/3WaXMyuTTRlGadpzDkQx5oWR6aNn065AgMBAAE=
-----END RSA PUBLIC KEY-----
onion-key-crosscert
-----BEGIN CROSSCERT-----
TCcCIv38fGcSzUO+DKxudFme2XBRuDkf5FjEr+6UbtDyuDjvjJDFYagN+zMJf/4K
RyBScjyKYK6MVMxAmf25QjAGx3KHV00ozVSzlN3WDAS2iicuKYvBsehG9g/tr6mI
luS5EoSKJIlmM2jOhN1QyR+Rpi37z/E6VTksk/bd69A=
-----END CROSSCERT-----
ntor-onion-key-crosscert 0
-----BEGIN ED25519 CERT-----
AQoABhNgARWTDubRgmA78DxUyKhyjT3uwg660OIztSqo++gjIoSuAEW8gwMcFUSD
mfkijKN6KyZxHloENGcgJMeJsR9kvfYp/u7O+VoPQ1kTxaw1lajTrnGQF+PV1MlK
niid4Nq5ZgM=
-----END ED25519 CERT-----
hidden-service-dir
contact 0x11F48D36 David Goulet <dgoulet AT ev0ke dot net>
ntor-onion-key qDcuoDpDD36bIapIbXBVhkIoiuMIXD9jNfjF1+7Vaks=
reject *:*
router-sig-ed25519 AxqrLz7QL/e+xGhhihs/rNzWsBW0Qla7Cwru1q88A5i+pcQBgfzfECiecptqYbDAsUPXMtwFsLp7Ls2BMOzvCQ
router-signature
-----BEGIN SIGNATURE-----
mSkveaqx79vzXLc6yC2+x8yZMQPe74ihw9tZJDdSOK5VqhzZOKHFM+JoD12noxQd
wgxa+IX0RG65KlguYE7NEZ7M6JOwr6r0zK/pWSZE8ZeHyt7FDx9ygc3k2ybQ6RWE
Hd7QXPiyVgs9cIgnvGFVt/5vzjMV+BELpOtehBrUJbs=
-----END SIGNATURE-----

I'm not sure if Truie is just doing something funky. identity-ed25519? router-sig-ed25519? None of these are things in the dir-spec, and its extra-info-digest line is invalid too.

Regardless of how this is being generated, seems like the DirAuths should be balking at such invalid content. Stem certainly doesn't like it when validation is enabled.

Child Tickets

Change History (13)

comment:1 Changed 2 years ago by nickm

Summary: Invalid extrainfo descriptor from Tor 0.2.7.1-alpha-devDocument which descriptor lines can have extra fields.

I'm changing the nature of this bug; it's a documentation issue in dir-spec IMO that Tor accepts (and expects others to accept) additional values for some (but not all) directory formats.

comment:2 Changed 2 years ago by isis

Cc: isis added

comment:3 Changed 2 years ago by atagar

Correction, I was confused - server, not a extrainfo descriptor. :)

As mentioned on irc proposal 228 lacks the 'here's what we're gonna paste into the dir-spec'. In the future please consider that to be a requirement for a proposal to be complete. Until you update the spec I don't have a clear indication of how Stem should be parsing this (... nor metrics-lib, bridgedb, etc).

comment:5 Changed 2 years ago by karsten

For reference, here's the extra-info descriptor that has been published together with the server descriptor above:

extra-info Truie A69221A7EC7498D2F88A0FB795261013FA36CAAE
identity-ed25519
-----BEGIN ED25519 CERT-----
AQQABhWIAZTz0r0KRagr6X9SHfm4oiIuMLVhJQQmNchtkBuR5SuFAQAgBAAVkw7m
0YJgO/A8VMioco097sIOutDiM7UqqPvoIyKErk1akOm3f6VAO/juOzxEeAgzgfA7
DiRsSjeVjp0xUdE43bXhK/8Uh+SPMwYKj47drjgTHGgzjTmlY9B/jFJ1Wgs=
-----END ED25519 CERT-----
published 2015-05-28 15:44:47
write-history 2015-05-28 14:56:33 (14400 s) 81495143424,65151201280,37724169216,49983378432,51962803200,37521272832
read-history 2015-05-28 14:56:33 (14400 s) 80257002496,62912677888,36183168000,48123964416,49894458368,35766819840
dirreq-write-history 2015-05-28 14:56:33 (14400 s) 1058615296,2111428608,1437853696,1677987840,1913356288,1799826432
dirreq-read-history 2015-05-28 14:56:33 (14400 s) 84944896,66253824,34560000,45114368,56260608,60781568
hidserv-stats-end 2015-05-28 12:33:30 (86400 s)
hidserv-rend-relayed-cells 2903056 delta_f=2048 epsilon=0.30 bin_size=1024
hidserv-dir-onions-seen 105 delta_f=8 epsilon=0.30 bin_size=8
router-sig-ed25519 4+ph0xwkIJGuYLcQYZvlYhiXqjZDIAPtdAoFemoBMuHQMoeFTWyVlLHE+CW0MyqJZP/Xp2SFcfniwdvxTCmHDQ
router-signature
-----BEGIN SIGNATURE-----
DPF1q1WOhUqUL900twocJbA1ESFzOtmEk71TbHKYT3bT4ImDVKojHFUsvcXq4n/q
VGmFS5wh5Neo9/cq1zTvflCKTK0vVAe+QUy3lvtwcZws0zEtdqu6O5aOkxnMV45z
rMnRp2A4dM3vN9rUQQjttnup20Ga/2GWIsjoDcAVYbo=
-----END SIGNATURE-----

comment:6 Changed 2 years ago by nickm

Milestone: Tor: 0.2.7.x-final

comment:7 Changed 2 years ago by nickm

Milestone: Tor: 0.2.7.x-finalTor: 0.2.8.x-final

comment:8 Changed 2 years ago by nickm

Keywords: 028-triage added

comment:9 Changed 2 years ago by nickm

Points: small/medium
Priority: normalmajor

comment:10 Changed 21 months ago by nickm

Priority: HighMedium

comment:11 Changed 21 months ago by nickm

Severity: Normal
Status: newneeds_review

Please review 'bug16227' in my public torspec repository. It documents the current behavior.

comment:12 Changed 21 months ago by atagar

Looks good to me. Thanks!

comment:13 Changed 21 months ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged it then. Thanks for the quick review!

Note: See TracTickets for help on using tickets.