Opened 3 years ago

Closed 3 years ago

Last modified 20 months ago

#16247 closed defect (fixed)

revert commit 49bdfbab or don't overwrite isolation_flags

Reported by: jojelino Owned by:
Priority: Medium Milestone: Tor: 0.2.7.x-final
Component: Core Tor/Tor Version: Tor: 0.2.6.3-alpha
Severity: Keywords: 026-backport, 2016-bug-retrospective
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Don't overwrite isolation flags.

Child Tickets

Attachments (1)

connection.c.diff (812 bytes) - added by jojelino 3 years ago.
Patch for this ticket.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 3 years ago by nickm

Keywords: 026-backport added
Milestone: Tor: 0.2.6.x-finalTor: 0.2.7.x-final
Priority: blockernormal

Say more, please? That code is used in constructing listeners and entry connections. There should not be a previous value of isolation_flags for it to ovewrite there, if I understand correctly. What am I missing?

Changed 3 years ago by jojelino

Attachment: connection.c.diff added

Patch for this ticket.

comment:2 Changed 3 years ago by yawning

Nice catch, though the bug is slightly misnamed. I think isolation_flags always gets propagated correctly, though the session_group member can end up getting trampled.

comment:3 Changed 3 years ago by nickm

Status: newneeds_review

This looks significant then. Can someone turn this into a branch against 0.2.6, with a changes file?

comment:5 Changed 3 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged; thanks, everyone!

comment:6 Changed 20 months ago by nickm

Keywords: 2016-bug-retrospective added

Mark more tickets for bug retrospective based on hand-review of changelogs from 0.2.5 onwards.

Note: See TracTickets for help on using tickets.