Opened 5 years ago

Closed 5 years ago

#16317 closed defect (fixed)

Minor setup.py issues.

Reported by: yawning Owned by: atagar
Priority: Medium Milestone:
Component: Archived/Nyx Version:
Severity: Keywords: installation, easy
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I gave the nyx setup.py script a whirl today, and it mostly worked though there were 2 minor issues, both more annoying than major bugs.

  • The #! line in the nyx script that gets installed should (if easy/possible) pull in the python executable name used for installation, instead of python. This is only an issue on systems that do not have /usr/bin/python, which admitedly are in a minority, but if I invoke setup.py as python2 setup.py, it would be nice if the right thing happened.
  • It looks like some of the documentation installation isn't honoring the destination. The script was ran as setup.py install --user which should put everything under ~/.local, but instead the installation process croaked half way through with error: [Errno 13] Permission denied: '/usr/share/man/man1/nyx.1.gz'.

Child Tickets

Change History (1)

comment:1 Changed 5 years ago by atagar

Resolution: fixed
Status: newclosed

Thanks Yawning! Made some adjustments to make our setup.py more intuitive.

You were absolutely right that we should adjust our shebang line. Distutils usually does this for us, so added a bit akin to what it does.

As for your second point, we have a couple arguments to our installer for additional resources...

  • --man-page to specify the man page location
  • --sample-path to specify the nyxrc.sample location

You're right that it's confusing that those don't respect --user or --prefix. This is actually normal for distutils (I was confused too that absolute resource paths aren't adjusted). That said, it *is* odd so changed our setup.py to not install those by default.

Feel free to reopen if you can think of anything else!

Note: See TracTickets for help on using tickets.