update cache isolation tests to use cache2 API
We need to update the cache isolation tests to use the new cache2 APIs and to account for #15933 (moved). Patch coming soon.
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Author
proposed fix
- Author
Arthur, please review the attached fix. You might know a better way to use the Task.jsm infrastructure. Thanks!
Trac:
Status: new to needs_review
Keywords: N/A deleted, TorBrowserTeam201506R added Replying to mcs:
Arthur, please review the attached fix. You might know a better way to use the Task.jsm infrastructure. Thanks!
Looks good to me! I also ran it and confirmed all tests pass. Maybe it should be a "fixup!" patch?
- Author
Replying to arthuredelstein:
Looks good to me! I also ran it and confirmed all tests pass. Maybe it should be a "fixup!" patch?
Yes, probably. Can you merge it into your TB ESR 38 branch (tweaking the commit message as appropriate)? Thanks!
Trac:
Keywords: TorBrowserTeam201506R deleted, TorBrowserTeam201506 added Replying to mcs:
Replying to arthuredelstein:
Looks good to me! I also ran it and confirmed all tests pass. Maybe it should be a "fixup!" patch?
Yes, probably. Can you merge it into your TB ESR 38 branch (tweaking the commit message as appropriate)? Thanks!
Done!
Trac:
Resolution: N/A to fixed
Status: needs_review to closed- Trac closed
closed