Opened 4 years ago

Closed 4 years ago

#16357 closed defect (fixed)

Wipe permissions using Mozilla API

Reported by: arthuredelstein Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: TorBrowserTeam201506R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Mozilla accepted our patch from #2950 (a pref to make Permissions manager DB memory-only), with the restriction that the pref, "permissions.memory_only" be read only at startup. In torbutton, we use the pref at runtime, but this is unnecessary. To wipe permissions, we can call Services.perms.removeAll();

Child Tickets

Change History (3)

comment:1 Changed 4 years ago by arthuredelstein

Keywords: TorBrowserTeam201506R added
Status: newneeds_review

comment:2 in reply to:  1 Changed 4 years ago by mcs

Replying to arthuredelstein:

Here's my patch:
https://github.com/arthuredelstein/torbutton/commit/16357

r=mcs. If I remember correctly, at the dev meeting on Monday you concluded that this cleared the in-memory permissions synchronously and that is sufficient because the info on disk is only read at startup.

comment:3 Changed 4 years ago by mikeperry

Resolution: fixed
Status: needs_reviewclosed

Yep. Merged and pushed.

Note: See TracTickets for help on using tickets.