Opened 23 months ago

Closed 23 months ago

Last modified 3 months ago

#16360 closed defect (fixed)

tor_main continues after failed crypto_early_init in tor_init

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 026-backport, 2016-bug-retrospective
Cc: nickm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

A typo in the return value from tor_init means that if crypto_early_init fails, tor_main can continue running, rather than returning with an error value.

This bug was introduced in commit d3fb846d8c98 possibly related to feature #4900, first released in 0.2.5.2-alpha.

Given it's a very simple fix, where tor continues to run half-initialised, we might want to backport it.

I'll post a branch very soon.

Child Tickets

Change History (4)

comment:1 Changed 23 months ago by teor

Branch: bug16360-failed-crypto-early-init
Repository: https://github.com/teor2345/tor.git
Content:

  • Make return value on failed crypto_early_init be -1, not 1
  • Changes file

comment:2 Changed 23 months ago by nickm

  • Resolution set to fixed
  • Status changed from new to closed

Cherry-picked to 0.2.5 and merged forwards. Thanks!

comment:3 Changed 13 months ago by nickm

  • Keywords 2016-bug-retrospective added

Mark more tickets for bug retrospective based on hand-review of changelogs from 0.2.5 onwards.

comment:4 Changed 3 months ago by nickm

  • Milestone changed from Tor: 0.2.7.x-final to Tor: 0.2.5.x-final
  • Severity set to Normal

(Verified that this bug doesn't exist in 0.2.4.)

Note: See TracTickets for help on using tickets.