Opened 4 years ago

Closed 4 years ago

#16416 closed defect (duplicate)

Regression tests for blob URI isolation are broken

Reported by: arthuredelstein Owned by: arthuredelstein
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: ff38-esr,
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

"Bug #15502, Part 2: Regression tests for blob URL isolation" is now broken, because Mozilla has apparently banned the use of Task.jsm in mochitests. So we'll need to rewrite this code with Promises to get it working again.

Child Tickets

Change History (7)

comment:1 Changed 4 years ago by arthuredelstein

Here's a patch that introduces a small helper script, task_spawn.js, which acts as a substitute for Task.spawn. So the remaining mochitest code for blob URL isolation remains pretty much untouched.

https://github.com/arthuredelstein/tor-browser/commit/16416

(This patch is now included in the branch ticket:16429#comment:2, so it's probably better to review it there.)

Last edited 4 years ago by arthuredelstein (previous) (diff)

comment:2 Changed 4 years ago by arthuredelstein

Keywords: TorBrowserTeam201506R added; TorBrowserTeam201506 removed
Status: newneeds_review

comment:3 Changed 4 years ago by mikeperry

Keywords: TorBrowserTeam201507R added; TorBrowserTeam201506R removed

Transfer review tickets to next month.

comment:4 Changed 4 years ago by arthuredelstein

To test this patch, run

./mach mochitest dom/base/test/test_tor_bug15502.html

comment:5 Changed 4 years ago by arthuredelstein

(See new message in comment:1)

comment:6 Changed 4 years ago by arthuredelstein

Keywords: added; TorBrowserTeam201507R removed

comment:7 Changed 4 years ago by arthuredelstein

Resolution: duplicate
Status: needs_reviewclosed
Note: See TracTickets for help on using tickets.