Opened 4 years ago

Closed 2 years ago

#16426 closed enhancement (fixed)

Add parse history for tarballs in archive directory

Reported by: karsten Owned by: metrics-team
Priority: Low Milestone:
Component: Metrics/Onionoo Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In #13600 we improved support for importing descriptor archives in bulk, but we didn't include a parse history for tarballs in the archive directory. Let's add one, so that service operators don't need to watch out and remove or move away tarballs after importing themselves.

Child Tickets

TicketTypeStatusOwnerSummary
#16540defectclosedkarstenClose the the updater's shared HttpUrlConnection socket if an exception occurs.

Attachments (1)

0001-Add-parse-history-for-archives.patch (3.7 KB) - added by leeroy 4 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 4 years ago by leeroy

Parent ID: #16424

Changed 4 years ago by leeroy

comment:2 Changed 4 years ago by leeroy

The patch implements the parse history and attempts to write the history earlier to avoid data loss.

comment:3 Changed 4 years ago by leeroy

Status: newneeds_review

comment:4 Changed 4 years ago by leeroy

Parent ID: #16424

comment:5 Changed 2 years ago by karsten

Owner: set to metrics-team
Severity: Normal
Status: needs_reviewassigned

Please find my task-16426 branch with an amended patch and another commit that fixes a bug that I found while testing.

comment:6 Changed 2 years ago by karsten

Status: assignedneeds_review

comment:7 Changed 2 years ago by iwakeh

Looks fine passes tests and checks. Merge ready.

I added some quick tweaks to things I noticed in the reviewed classes.
Please review three more commits in my branch.

comment:8 Changed 2 years ago by iwakeh

PS: I assume we decided at some point to not add tests for the history tracking functionality?

comment:9 Changed 2 years ago by karsten

Resolution: fixed
Status: needs_reviewclosed

Great, thanks for checking! Merged together with your three commits.

Regarding testing, I'd say we should rather replace the duplicate code for history tracking with functionality from metrics-lib than write tests for Onionoo. But that's for another ticket/time.

Closing. Thanks again!

Note: See TracTickets for help on using tickets.