Opened 4 years ago

Closed 4 years ago

#16428 closed enhancement (fixed)

Use internal update URL for TorLauncher

Reported by: gk Owned by: brade
Priority: Medium Milestone:
Component: Applications/Tor Launcher Version:
Severity: Keywords: TorBrowserTeam201506R
Cc: mcs Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In #10682 we disabled update pings by setting the update URL to https://127.0.0.1 which caused #13129. We can do something more clever without sending pings AND causing #13129 as shown in comment:13:ticket:16200.

Child Tickets

Change History (4)

comment:1 Changed 4 years ago by mcs

Cc: mcs added

comment:2 Changed 4 years ago by gk

Keywords: TorBrowserTeam201506R added; TorBrowserTeam201506 removed
Status: newneeds_review

bug_16248 (https://gitweb.torproject.org/user/gk/tor-launcher.git/commit/?h=bug_16428) in my public TorLauncher repo has the fix. I see complaints in the console now about the update manifest not being valid XML but I think this is okay.

comment:3 Changed 4 years ago by mcs

r=mcs
I saw the console messages about the XML being invalid as well when I experimented with this in Torbutton, but this solution is still a lot better than touching the network.

comment:4 Changed 4 years ago by mikeperry

Resolution: fixed
Status: needs_reviewclosed

Merged. I filed #16442 for the error console cleanup, but I don't think we need that for 5.0a3.

Note: See TracTickets for help on using tickets.