Opened 4 years ago

Closed 4 years ago

#16438 closed enhancement (fixed)

Enable control port in chutney Tor clients

Reported by: donncha Owned by: nickm
Priority: Medium Milestone:
Component: Core Tor/Chutney Version:
Severity: Keywords: SponsorS
Cc: teor, nickm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I'd like to be able to use chutney to perform integration testing for OnionBalance. I need access to a Tor client's control port but the control port is not enabled in the current client.tmpl.

I've pushed a trivial patch to my Github repo at https://github.com/DonnchaC/chutney/pull/1/files

Child Tickets

Change History (7)

comment:1 Changed 4 years ago by teor

Status: newneeds_review

I can look into this.

comment:2 Changed 4 years ago by teor

Branch: client-control-port
Repository: https://github.com/DonnchaC/chutney.git
Commits:

  • Enable control port in client.tmpl

comment:3 Changed 4 years ago by teor

Review

This change can be merged:

  • I have confirmed that clients and bridge clients generate ControlPort and CookieAuthentication lines
  • I have confirmed that nyx can connect to the chutney client's control port
  • Existing code and src/test/test-network.sh tests work as expected

comment:4 Changed 4 years ago by teor

Status: needs_reviewneeds_information

Using ControlSocket doesn't expose the port to other processes.
Note: the ControlSocket line would be disabled by chutney on older versions of Tor which don't have that feature.

donncha, would you like to change the patch to use ControlSocket instead?

comment:5 Changed 4 years ago by teor

Status: needs_informationneeds_review

I think we can we merge this patch as is. Using ControlSocket will only work on the latest tor versions, so it's best to use ControlPort.

It's in DonnchaC's github repository at:

Branch: client-control-port
Repository: ​https://github.com/DonnchaC/chutney.git
Commits:

  • Enable control port in client.tmpl

comment:6 Changed 4 years ago by teor

Keywords: SponsorS added

nickm, this can be merged

comment:7 Changed 4 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Looks fine; merged

Note: See TracTickets for help on using tickets.