Opened 3 years ago

Closed 2 years ago

Last modified 4 months ago

#16441 closed defect (fixed)

8-month-old Tor Browser offers to "Reset Tor Browser", removes extensions

Reported by: dcf Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-security, tbb-usability, TorBrowserTeam201512R, tbb-no-uplift
Cc: ioerror, gk, mcs, brade Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I started an old copy of Tor Browser 4.0 I had in a directory. From file times it looks like it was last run on 2014-10-21, 8 months ago (today is 2015-06-24). When I started it, the about:tor page showed a banner at the bottom

It looks like you haven't started Tor Browser in a while. Do you want to clean it up for a fresh, like-new experience? And by the way, welcome back!

with a button that says "Reset Tor Browser..."

When I click on the button, the browser restarts and gives me the plain Firefox start page, with the Firefox logo and everything. It looks like all the extensions are gone (HTTPS-Everywhere, NoScript, Torbutton, Tor Launcher). check.torproject.org says the browser is using Tor. I also got a banner offering to update to 5.0a2.

I was trying the instructions from doc/TorBrowser/Hacking#UsinganExistingTorProcess so I had run

export TOR_SOCKS_PORT=9050
export TOR_SKIP_LAUNCH=1
./start-tor-browser

I don't know if that had anything to do with it.

Child Tickets

Attachments (4)

refresh.png (6.3 KB) - added by dcf 3 years ago.
The startup banner.
startpage.png (68.3 KB) - added by dcf 3 years ago.
The page shown after restarting after clicking the reset button.
addons.png (38.9 KB) - added by dcf 3 years ago.
about:addons after clicking the reset button.
check.png (35.8 KB) - added by dcf 3 years ago.
check.torproject.org after clicking the reset button.

Download all attachments as: .zip

Change History (12)

Changed 3 years ago by dcf

Attachment: refresh.png added

The startup banner.

Changed 3 years ago by dcf

Attachment: startpage.png added

The page shown after restarting after clicking the reset button.

Changed 3 years ago by dcf

Attachment: addons.png added

about:addons after clicking the reset button.

Changed 3 years ago by dcf

Attachment: check.png added

check.torproject.org after clicking the reset button.

comment:1 Changed 3 years ago by dcf

The bottom banner.
The startup banner.

Screenshots.
The page shown after restarting after clicking the reset button.

about:addons after clicking the reset button.

check.torproject.org after clicking the reset button.

comment:2 Changed 3 years ago by dcf

When I try exiting the browser and running it a second time, I get a dialog "Your Firefox profile cannot be loaded. It may be missing or inaccessible."

comment:3 Changed 3 years ago by gk

Cc: ioerror gk added
Keywords: tbb-security tbb-usability added
Priority: minormajor

#16514 is a duplicate. Quoting from there:

Lunar suggests we need to do something with the browser.disableResetPrompt option.

comment:4 Changed 3 years ago by mcs

Cc: mcs added

comment:5 in reply to:  3 Changed 3 years ago by dcf

Replying to gk:

#16514 is a duplicate. Quoting from there:

Lunar suggests we need to do something with the browser.disableResetPrompt option.

Note that according to https://bugzilla.mozilla.org/show_bug.cgi?id=955950#c42, browser.disableResetPrompt is a "hidden preference" that doesn't appear in about:config by default.

comment:6 Changed 2 years ago by mcs

Cc: brade added
Keywords: TorBrowserTeam201512R added
Severity: Normal
Status: newneeds_review

I think we should disable this now since it is a trivial change. A fix is available here:
https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug16441-01&id=ca5a7a43a2873a84b69f7d8b1f00e3baff664c6c

Note that if someone loads about:support they will still see a "Refresh Tor Browser" button there (maybe we should open another ticket to cover that obscure case).

Also note that the automated pref tests need more work; see #17809.

comment:7 Changed 2 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good to me and as we still have to wait for Mozilla to start our build it will go into the upcoming stable as well. (tor-browser-38.5.0esr-5.0-1: b97f8e248b868725f481fb1656e19d1536c96547 and tor-browser-38.4.0esr-5.5-1: 549d97d99b477b1764bb4875a964c0dbc6d694e3).

comment:8 Changed 4 months ago by arthuredelstein

Keywords: tbb-no-uplift added
Note: See TracTickets for help on using tickets.