Opened 3 years ago

Closed 3 years ago

#16488 closed task (fixed)

Remove "Sign in to Sync" from the menu

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: tbb-usability, TorBrowserTeam201507R, tbb-5.0a
Cc: brade, mcs Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We should clean up Tor Browser's UI for 5.0. E.g. there is no need to have the Share this page button taking space away from the task bar.

Child Tickets

Change History (8)

comment:1 Changed 3 years ago by gk

Summary: Clean up Torbrowser's UI for 5.0 stableClean up Tor Browser's UI for 5.0 stable

comment:2 Changed 3 years ago by mikeperry

I removed 'Share this page' in #16510. The only other thing we might consider for this is removing 'Sign in to Sync', though that seems to require a XUL patch.

comment:3 Changed 3 years ago by mikeperry

Summary: Clean up Tor Browser's UI for 5.0 stableRemove "Sign in to Sync" from the menu

comment:4 Changed 3 years ago by mcs

Cc: brade mcs added

Kathy and I can create a XUL patch to remove the "Sign in to Sync" item. Should we add a pref. to allow people to turn this back on or do we want to remove Firefox Sync entirely as a feature? If we want to remove it entirely and unconditionally, we should also remove the following:

about:preferences#sync
about:accounts
about:sync-log
about:sync-progress
about:sync-tabs

I am not sure how much work that will be though.

comment:5 in reply to:  4 ; Changed 3 years ago by gk

Replying to mcs:

Kathy and I can create a XUL patch to remove the "Sign in to Sync" item. Should we add a pref. to allow people to turn this back on or do we want to remove Firefox Sync entirely as a feature? If we want to remove it entirely and unconditionally, we should also remove the following:

about:preferences#sync
about:accounts
about:sync-log
about:sync-progress
about:sync-tabs

I am not sure how much work that will be though.

There is still #10368 and I think we can keep the feature until we clearly get the impression this is actually harmful to use. Thus, removing it from the toolbar seems to be enough to me and ideally we have a pref to make it somehow available again.

Last edited 3 years ago by gk (previous) (diff)

comment:6 in reply to:  5 Changed 3 years ago by mcs

Replying to gk:

There is still #10368 and I think we can keep the feature until we clearly get the impression this is actually harmful to use. Thus, removing it from the toolbar seems to be enough to me and ideally we have a pref to make it somehow available again.

OK; that makes sense. After I posted my comment here I found several related tickets: #7188, #10367, and #10368.

comment:7 Changed 3 years ago by mcs

Keywords: TorBrowserTeam201507R added; TorBrowserTeam201507 removed
Status: newneeds_review

comment:8 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good, thanks. Merge with commit 522558c8211987bcfd79685e633d47a455407355.

Note: See TracTickets for help on using tickets.