Tor Browser 5.0a3 has Yahoo as default search engine

A user noticed this regression. It looks like it may be related to a new interface in the search box.

added TorBrowserTeam201507R component::applications/tor browser ff38-esr owner::tbb-team priority::medium resolution::fixed status::closed type::defect labels

Trac:
Keywords: N/A deleted, ff38-esr added

Here's a patch for review, sets Disconnect to the default search engine, and ensures that the name "Disconnect" is used in the search box drop down menu. I confirmed that Disconnect is the default in the Omnibox, search box, and when selected text is right-clicked.

https://github.com/arthuredelstein/tor-browser/commit/16522

Trac:
Status: new to needs_review
Keywords: N/A deleted, TorBrowserTeam201507R added

Marked #16509 (moved) as a duplicate of this.

This looks fine to me. I tested and merged it for 5.0-next.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

Replying to mikeperry:

This looks fine to me. I tested and merged it for 5.0-next.

Last time you argued against using "Disconnect" in the search boxes due to concerns users could get confused (maybe they think they are disconnecting from the Tor network). I am fine with that argumentation. Could you explain what changed your mind? The "Search Search for" instead "Search Disconnect for" issue? Or was this an oversight? Or...?

The omnibox text in FF38 now says "Search" in it regardless of the selected engine. Hence, it seemed better to name the Disconnect search choice as "Disconnect", so that people can select it and not have it say "Your default engine is now 'Search'".

closed

mentioned in issue #16547 (moved)

moved to tpo/applications/tor-browser#16522 (closed)

mentioned in issue tpo/applications/tor-browser#16547 (closed)