Opened 9 years ago

Closed 9 years ago

#1656 closed enhancement (implemented)

More efficient ruleset checking

Reported by: pde Owned by: pde
Priority: Medium Milestone:
Component: HTTPS Everywhere/EFF-HTTPS Everywhere Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: #2161 Points:
Reviewer: Sponsor:

Description

Currently every request from the browser occurs an overhead that is O(N) where N is the number of rules (or rulesets with match_rules).

This is not good enough, especially if we intend to include all the rules people are submitting.

O(1) lookups should be possible. One way is a dictionary of target domains, with lookups looking something like this:

If the request is for content at blah.thing.com, we look up

*.thing.com, thing.*.com, blah.thing.*

in the dictionary. For the time being, rulesets should be able to signal what domains they target in at least that level of specificity

Eg, Google.xml targets:

google.*
www.google.*
google.com.*
www.google.com.*
google.co.*
www.google.co.*

BUT, if we ever had to worry about *.google.* this wouldn't be enough...

Child Tickets

Change History (5)

comment:1 Changed 9 years ago by bee

Resolution: duplicate
Status: newclosed

Good thing i found this!!!!!!!!!!!!! Mikeperry's bacteria are spreading!!!!! This is a non-working duplicated idea of my working concept!!!!!! I even wrote the code!!!!(it works!!!) beware of mike-perry!!!! he's epidemic and usual to despise the hard work of the others, with the only result to nail down his software!!!!! yeah!!! don't copy him!!! So, i wrote the code for you too!!!!!!!!! you don't have to discard and rewrite it all again!!! Also, it's because looking at your mixed up ideas, you couldn't write it!!! lol!!!!!!!! (haha i'm kidding!!!!!!or almost!!!! lolol!!!!!)

https://trac.torproject.org/projects/tor/ticket/1614 (the list!!!!!)

bye!!!!!!!!!!
~bee!!!!!

comment:2 Changed 9 years ago by nickm

Resolution: duplicate
Status: closedreopened

Hey, bee, don't close tickets that you didn't open. That's for the the project devs to do.

comment:3 Changed 9 years ago by bee

Ha!!! i'm sorry!!!!! i marked this entry as a duplicate and the software closed the bug as well!!! i didn't meant to!!

bye!!!!! ~bee!!!

comment:4 Changed 9 years ago by mikeperry

Parent ID: #2161

comment:5 Changed 9 years ago by pde

Resolution: implemented
Status: reopenedclosed

Now implemented in master!

Note: See TracTickets for help on using tickets.