Opened 3 years ago

Closed 3 years ago

#16563 closed defect (fixed)

Log function prettyprint on os x sure is verbose

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: 0.2.8.x-final
Component: Core Tor/Tor Version:
Severity: Keywords:
Cc: special Actual Points:
Parent ID: Points: small
Reviewer: Sponsor:

Description

On Linux, my debug-level log says things like

Jul 12 12:19:17.904 [debug] choose_good_middle_server(): Contemplating intermediate hop 1: random choice.

I just saw a debug level log from osx, and it said

Jul 12 11:45:54.528 [debug] const node_t *choose_good_middle_server(uint8_t, cpath_build_state_t *, crypt_path_t *, int): Contemplating intermediate hop 1: random choice.

Wow! Is that level of detail really desired?

Child Tickets

Change History (7)

comment:1 Changed 3 years ago by teor

Given we don't overload functions, I can't see how the argument and return value types are useful.

This may be a clang vs gcc thing, perhaps clang is more verbose with __FUNCTION__ (or similar)?

comment:2 Changed 3 years ago by arma

Agree. I find that the extra decorations make the lines much harder to read.

comment:3 Changed 3 years ago by nickm

Keywords: PostFreeze027 added

I'd merge patches for these for 0.2.7 if they come in on time. In some cases, that will require figuring out an as-yet-unsolved bugs.

comment:4 Changed 3 years ago by nickm

Keywords: PostFreeze027 removed
Milestone: Tor: 0.2.7.x-finalTor: 0.2.8.x-final

Moving these tickets into 0.2.8. Not expecting to take patches for any into 0.2.7 at this late date. As usual, please say something if you disagree! :)

comment:5 Changed 3 years ago by nickm

Points: small

comment:6 Changed 3 years ago by TvdW

Status: newneeds_review

This happens because tor uses __PRETTY_FUNCTION__ instead of __FUNCTION_.

Patch: https://github.com/TvdW/tor/commits/fix-16563

Last edited 3 years ago by TvdW (previous) (diff)

comment:7 Changed 3 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Seems okay. Merged! Also, added a changes file. (Please include a changes file in the future, if you remember.)

Note: See TracTickets for help on using tickets.