Opened 4 years ago

Last modified 2 years ago

#16598 accepted defect

fsync ed25519 master key files before closing them.

Reported by: nickm Owned by: nickm
Priority: Very Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: ed25519 tor-relay fsync easy
Cc: Actual Points:
Parent ID: Points: .2
Reviewer: Sponsor:

Description

Weasel says this is a good idea, and IMO it can't hurt.

Child Tickets

Change History (12)

comment:1 Changed 4 years ago by nickm

Parent ID: #16530

comment:2 Changed 4 years ago by nickm

Keywords: ed25519 sponsorU TorCoreTeam201508 added
Owner: set to nickm
Status: newaccepted

comment:3 Changed 4 years ago by teor

Do we want to do the RSA keys while we're at it?
We don't seem to be doing fsync at all in the current code, unless it's spelt differently.

comment:4 Changed 4 years ago by nickm

Keywords: TorCoreTeam201508 removed
Milestone: Tor: 0.2.7.x-finalTor: 0.2.???

comment:5 Changed 4 years ago by nickm

Keywords: ed25519,sponsorUed25519, sponsorU
Sponsor: SponsorU

Bulk-replace SponsorU keyword with SponsorU field.

comment:6 Changed 4 years ago by isis

Keywords: sponsorU removed
Priority: normaltrivial

Marking as trivial because if we crash before successfully saving the key, it's fine because we just generate a new one the next time.

comment:7 Changed 3 years ago by isabela

Sponsor: SponsorUSponsorU-can

comment:8 Changed 3 years ago by nickm

Points: .2
Severity: Normal
Sponsor: SponsorU-can

comment:9 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:10 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:11 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:12 Changed 2 years ago by nickm

Keywords: tor-relay fsync easy added
Note: See TracTickets for help on using tickets.