Spoof Timezone from Firefox patch

We should directly patch Firefox to provide a way to spoof the timezone, instead of our hacky env var approach in Torbutton.

added TorBrowserTeam201611R component::applications/tor browser owner::tbb-team priority::medium resolution::fixed severity::normal sponsor::U status::closed tbb-fingerprinting tbb-torbutton-conversion type::defect labels

Trac:
Sponsor: N/A to N/A
Severity: N/A to Normal
Cc: N/A to mcs

Trac:
Sponsor: N/A to SponsorU

For future reference: This is currently done in torbutton_set_timezone() within torbutton.js

Trac:
Reviewer: N/A to N/A

Getting important SponsorU things on our August radar.

Trac:
Keywords: N/A deleted, TorBrowserTeam201608 added

Copied from #4545 (moved).

Angry user said:

Reveals local time of my PC instead of UTC check out: "To Locale String" on this site: https://www.browserleaks.com/javascript ​https://blog.torproject.org/blog/tor-browser-602-released#comment-191587

Tickets for September.

Trac:
Keywords: TorBrowserTeam201608 deleted, TorBrowserTeam201609 added

Trac:
Cc: mcs to mcs, arthuredelstein

Moving SponsorU items to October.

Trac:
Keywords: TorBrowserTeam201609 deleted, TorBrowserTeam201610 added

Moving tickets over to November.

Trac:
Keywords: TorBrowserTeam201610 deleted, TorBrowserTeam201611 added

Here's a branch that provides a static pref for timezone spoofing. I also tried to implement an alternative "live" pref, but the problem is rather complex and I don't want to delay further. I figure it's good to have a working patch now and we can revisit it during uplift.

There are two patches (pref implemented, and pref set): https://github.com/arthuredelstein/tor-browser/commits/16622+3

Here's a patch that removes the functionality from torbutton: https://github.com/arthuredelstein/torbutton/commit/16622

Trac:
Keywords: TorBrowserTeam201611 deleted, TorBrowserTeam201611R added
Status: new to needs_review

Looks good to me.

Trac:
Cc: mcs, arthuredelstein to mcs, brade, arthuredelstein

Trac:
Cc: mcs, brade, arthuredelstein to mcs, brade, arthuredelstein, gk

r=mcs This looks good to me too.

Fixed on Torbutton's master branch with commit 86dd5f30f7b6b29d6eb7e1947c225cd3cc43021b and on tor-browser-45.5.0esr-6.5-1 with commits d973b7ebaa5e93ee8e4b6b9f07ec51333687087b and 76d74d18040e22fdb6b100b4638078c2e83fa195, thanks!

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

Trac:
Keywords: N/A deleted, tbb-fingerprinting added

closed

mentioned in issue #18112 (moved)

mentioned in issue #27268 (moved)

moved to tpo/applications/tor-browser#16622 (closed)

mentioned in issue tpo/applications/tor-browser#18112 (closed)