Opened 4 years ago

Closed 3 years ago

#16623 closed defect (fixed)

Unify our external app blocker with Firefox's

Reported by: mikeperry Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-torbutton-conversion
Cc: mcs, brade, arthuredelstein Actual Points:
Parent ID: Points:
Reviewer: Sponsor: SponsorU

Description

Firefox tries to prompt the user before opening external apps, but often fails. This is why we created the Torbutton external-app-blocker.js component. Can we unify this approach with the existing Firefox prefs for network.protocol-handler.warn-external.*?

Child Tickets

Attachments (1)

download.png (65.9 KB) - added by mcs 3 years ago.
Mockup of integrated download dialog

Download all attachments as: .zip

Change History (10)

comment:1 Changed 3 years ago by gk

Sponsor: SponsorU

comment:2 Changed 3 years ago by gk

Cc: mcs brade added
Severity: Normal

Changed 3 years ago by mcs

Attachment: download.png added

Mockup of integrated download dialog

comment:3 Changed 3 years ago by mcs

Kathy and I have been looking at this ticket and #19273. Our current leaning is to integrate the Tor-specific warning text into Firefox's dialog (using a XUL overlay). We will also need to make some small changes to the core browser code to ensure that all actions default to "Always ask" for external files and protocols. Here is a mockup:

Mockup of integrated download dialog

What do other people think of this approach?

comment:4 Changed 3 years ago by gk

It might be too late to block launching applications at this point. See: comment:74:ticket:9901.

comment:5 in reply to:  4 Changed 3 years ago by mcs

Replying to gk:

It might be too late to block launching applications at this point. See: comment:74:ticket:9901.

Thanks for that pointer. Since it is difficult to prove that external applications will not be launched without prompting (especially given the complexity of the external app handling code), Kathy and I plan to preserve the existing, Tor-specific dialog. Patches will be posted in #19273.

comment:6 Changed 3 years ago by arthuredelstein

Cc: arthuredelstein added

comment:7 Changed 3 years ago by gk

Status: newneeds_information

mcs/brade: Do you think this is done or is this a ticket for a patch that fixes network.protocol-handler.warn-external.*?

comment:8 in reply to:  7 Changed 3 years ago by mcs

Replying to gk:

mcs/brade: Do you think this is done or is this a ticket for a patch that fixes network.protocol-handler.warn-external.*?

Since we decided to keep our safe approach of using a Tor-specific prompt, I think this ticket can be closed (unless you think we will revisit that decision in the future).

I think someone should fix https://bugzilla.mozilla.org/show_bug.cgi?id=440892 (maybe be simply removing the network.protocol-handler.warn-external.* prefererences, since Firefox has not supported them for a long time). But that is a Mozilla issue, really.

comment:9 Changed 3 years ago by gk

Resolution: fixed
Status: needs_informationclosed

Closing this then as fixed by #19273.

Note: See TracTickets for help on using tickets.