Opened 5 years ago

Last modified 4 years ago

#16624 new task

Improper key passed to nsHttpChannel::DoInvalidateCacheEntry()?

Reported by: mikeperry Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mozilla-merge, ff52-esr
Cc: arthuredelstein, brade, mcs, gk Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by arthuredelstein)

During the cache2 review in #13035, mcs noticed that an empty key was being passed to nsHttpChannel::DoInvalidateCacheEntry().

nsHttpChannel::DoInvalidateCacheEntry() to use our modified (isolated) cache keys. That would involve passing a non-empty string as the second parameter to cacheStorage->AsyncDoomURI() within that method. This is not new code and not something we patched in the past... and Kathy and I do not understand the implications of not patching it. But it seems like the wrong key is being used there.

I replied:

I have not dug through all of the eviction code (there sure are a lot of codepaths involved there), but my initial take is that since Mozilla has been using this same extension key to isolate caching for POST requests, it probably is not a serious issue to omit it, since the original code would have been experiencing similar problems even before our isolation made further use of this key...

We should ask Mozilla for an opinion. This may be a bug in their code, too.

Child Tickets

Change History (6)

comment:1 Changed 5 years ago by mikeperry

Keywords: tbb-mozilla-merge added; tbb-mozilla-upstream removed

comment:2 Changed 5 years ago by gk

Cc: gk added

comment:3 Changed 5 years ago by mcs

Cc: brade added

comment:4 Changed 4 years ago by bugzilla

Severity: Normal

It's time to ask Mozilla (during mozilla52).

comment:5 Changed 4 years ago by arthuredelstein

Description: modified (diff)

comment:6 Changed 4 years ago by gk

Keywords: ff52-esr added

We should double-check that while doing the ESR upgrade dance.

Note: See TracTickets for help on using tickets.