Opened 4 years ago

Closed 4 years ago

#16626 closed enhancement (fixed)

Improved resource handling using try-with-resources

Reported by: firebrand Owned by:
Priority: Low Milestone:
Component: Metrics/Onionoo Version:
Severity: Keywords:
Cc: ter.one.leeboi@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

There are many places in the onionoo-code where file and stream handles are not correctly closed within finally blocks. This patch reworks these places to use Java 7's new try-with-resources functionality.

Child Tickets

Attachments (1)

onionoo-072115-trywith.patch (26.6 KB) - added by firebrand 4 years ago.

Download all attachments as: .zip

Change History (3)

Changed 4 years ago by firebrand

comment:1 Changed 4 years ago by leeroy

Cc: ter.one.leeboi@… added

comment:2 Changed 4 years ago by karsten

Resolution: fixed
Status: newclosed

Looks good. Tweaked some trivial whitespace issues and merged. Thanks! Closing.

Note: See TracTickets for help on using tickets.