Opened 4 years ago

Last modified 2 years ago

#16633 new enhancement

Enable and isolate Firefox connection prediction

Reported by: mikeperry Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-performance
Cc: gk, luke.crouch@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In #16625, we found that Firefox's network prediction was partially disabled due to our use of SOCKS proxy settings, and also that it wasn't properly getting isolated in the cache or elsewhere.

We should try to enable this, though, as it will likely represent a significant decrease in page load times. If we enable isolation, the only real privacy issue is prediction for link hover, and that can be easily disabled in Predictor::PredictForLink() (there already is a check to disable it for HTTPS links).

Child Tickets

Change History (7)

comment:1 Changed 4 years ago by mikeperry

I have a quick sketch of what we'd need to hack to perform a basic test of this here:
https://gitweb.torproject.org/user/mikeperry/tor-browser.git/commit/?h=bug16633-sketch

That might be a good starting point to see if this thing works at all with a SOCKS proxy set, since it seems very much like the original prediction code wasn't ever tested for that case.

comment:2 Changed 4 years ago by gk

Cc: gk added

comment:3 in reply to:  1 Changed 4 years ago by gk

Replying to mikeperry:

I have a quick sketch of what we'd need to hack to perform a basic test of this here:
https://gitweb.torproject.org/user/mikeperry/tor-browser.git/commit/?h=bug16633-sketch

That might be a good starting point to see if this thing works at all with a SOCKS proxy set, since it seems very much like the original prediction code wasn't ever tested for that case.

Keep "The seer does not record any data, nor does it take any action, when in private browsing mode." in mind. (https://wiki.mozilla.org/Privacy/Reviews/Necko)

Last edited 4 years ago by gk (previous) (diff)

comment:4 Changed 4 years ago by gk

And keep #16324 in mind where speculative connect is somehow working (making connections while being in private-browsing mode AND using a proxy AND network.predictor.enabled being set to false).

comment:5 Changed 3 years ago by bugzilla

Keywords: tbb-performance added; tbb-usability-performance performance removed
Severity: Normal

Ticket about improving the performance, wow!

comment:6 in reply to:  5 Changed 3 years ago by cypherpunks

Replying to bugzilla:

Ticket about improving the performance, wow!

What, you're saying Tor has a problem with performance? Blasphemy!

Seriously though, couldn't this make website fingerprinting easier?

comment:7 Changed 2 years ago by groovecoder

Cc: luke.crouch@… added
Note: See TracTickets for help on using tickets.