Opened 4 years ago

Last modified 2 years ago

#16648 new defect

Libevent configuration doesn't use pkg-config

Reported by: mmcc Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-build libevent pkg-config
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

This interferes with some packages/ports (e.g. OpenBSD's) because the system's libevent CFLAGS and LIBS aren't used.

Pkg-config would probably make the dev's lives easier, too. Because the project is dropping support for older libevent versions, now's a good time.

Thoughts? Would this break any non-Unixy platforms?

Child Tickets

Change History (9)

comment:1 Changed 4 years ago by nickm

We still support libevent back through libevent 1.3e, and I'm about 99% sure that version didn't have pkg-config support.

I'd love to do it optionally, so that it supports pkg-config if it *is* present, but beware: our current autoconf library search logic is full of dragons. :)

comment:2 Changed 4 years ago by mmcc

Oh, I wasn't aware of that. That makes #16651 the more realistic option for now.

comment:3 Changed 4 years ago by nickm

Well, I wouldn't want to be too hasty. Our existing library-search code is downright horrible, and having a migration path towards pkg-config would be appreciated by a lot of folks.

comment:4 Changed 4 years ago by nickm

Well, I wouldn't want to be too hasty. Our existing library-search code is downright horrible, and having a migration path towards pkg-config would be appreciated by a lot of folks.

comment:5 Changed 4 years ago by nickm

Milestone: Tor: 0.2.???

comment:6 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:7 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:8 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:9 Changed 2 years ago by nickm

Keywords: tor-build libevent pkg-config added
Severity: Normal
Note: See TracTickets for help on using tickets.