Opened 4 years ago

Closed 4 years ago

#16661 closed defect (fixed)

check-prerequisites.sh does not check for libyaml-perl

Reported by: dcf Owned by: boklm
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: tbb-gitian, TorBrowserTeam201508R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I did a make alpha of tbb-5.0a3-build5 and it failed at the very end, apparently because of a missing libyaml-perl. mikeperry said that check-prerequisites.sh should check for it in advance.

****** Mac Bundle complete ******

../tools/update-responses/download_missing_versions alpha
Can't locate YAML.pm in @INC (@INC contains: /etc/perl /usr/local/lib/perl/5.14.2 /usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14 /usr/share/perl/5.14 /usr/local/lib/site_perl .) at ../tools/update-responses/download_missing_versions line 7.
BEGIN failed--compilation aborted at ../tools/update-responses/download_missing_versions line 7.
make: *** [incrementals-alpha] Error 2

Child Tickets

Change History (6)

comment:1 Changed 4 years ago by boklm

Keywords: tbb-gitian TorBrowserTeam201508R added
Status: newneeds_review

I attached a patch to check for all dependencies of the update_responses script.

comment:2 Changed 4 years ago by gk

Hm... I get some missing dependencies and the hint to run

sudo apt-get install  libfindbin-libs-perl libdigest-sha-perl

on my Debian machine. But I don't have problems generating incrementals and regular MAR files on it. Thus, these packages do not seem to be needed. Are these special Ubuntu requirements?

comment:3 Changed 4 years ago by boklm

Hmm, you're right, those packages are not needed: the Digest::SHA module is already provided by the perl package, and FindBin by the perl-modules package. When I made this list I looked at corresponding packages for all the modules used forgetting that some are already provided in the perl package.

I'm uploading a new version of the patch without those 2 packages.

comment:4 Changed 4 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Merged v2 as commit 569d57637d127d4719cd3de0ba13f5430acddfd4 into master and as commit 9d47b46bc5299c9ba41c49ed589caeda8ae18e5e into maint-5.0.

Note: See TracTickets for help on using tickets.