Opened 4 years ago

Last modified 15 months ago

#16686 new defect

Migrate all font fingerprinting patches to tor-browser.git

Reported by: arthuredelstein Owned by: arthuredelstein
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-fingerprinting-fonts, TorBrowserTeam201603
Cc: gk Actual Points:
Parent ID: #18097 Points:
Reviewer: Sponsor:

Description

Right now, our font fingerprinting patches are divided between tor-browser.git and tor-browser-bundle.git. We'd like to move all patches to tor-browser.git.

From our discussion at ticket:13313#comment:25:

arthuredelstein:

[We could] add the Noto fonts directly to the tor-browser.git repo, and add something in the Mozilla build scripts to install them in the directory where fonts are bundled. That would avoid modifying tor-browser-bundle.git altogether.

gk:

I think this makes sense. Another thing that bothers me with the currently proposed solution is that it makes bisecting quite error-prone. Although this is not documented yet the fastest approach is to just take an existing Tor Browser bundle and just bisect the tor-browser parts copying the result over the respective bundle parts with each iteration. This is not working anymore with having so many parts in tor-browser-bundle.git. Having everything in tor-browser could help us debug issues due to font updates easier as well.

One issue is whether we want to use hinted or unhinted Noto fonts. If some OSs are incapable of making use of hinting, then we may decide to turn off hinting on all platforms. In that case we could bundle just unhinted fonts. OTOH, hinting maybe looks nicer, and it may be difficult to prevent fingerprinting Windows vs Linux vs Mac, so it's worth thinking about the tradeoff.

Child Tickets

Change History (12)

comment:1 Changed 4 years ago by arthuredelstein

Keywords: tbb-5.0a4 removed

comment:2 Changed 4 years ago by mikeperry

Keywords: TorBrowserTeam201508 added; TorBrowserTeam201507 removed

comment:3 Changed 3 years ago by mikeperry

Keywords: TorBrowserTeam201509 added; TorBrowserTeam201508 removed

Move remaining August tickets to September.

comment:4 Changed 3 years ago by gk

Keywords: TorBrowserTeam201510 added; TorBrowserTeam201509 removed

Moving Tor Browser tickets to October 2015.

comment:5 Changed 3 years ago by gk

Keywords: TorBrowserTeam201511 added; TorBrowserTeam201510 removed

comment:6 Changed 3 years ago by mikeperry

Keywords: TorBrowserTeam201512 added; TorBrowserTeam201511 removed

comment:7 Changed 3 years ago by gk

Keywords: TorBrowserTeam201601 added; TorBrowserTeam201512 removed

Tickets for Jan 2016.

comment:8 Changed 3 years ago by arthuredelstein

Parent ID: 18097

comment:9 Changed 3 years ago by arthuredelstein

Parent ID: 18097#18097

comment:10 Changed 3 years ago by gk

Keywords: TorBrowserTeam201602 added; TorBrowserTeam201601 removed

Putting stuff on the radar for February.

comment:11 Changed 3 years ago by gk

Keywords: TorBrowserTeam201603 added; TorBrowserTeam201602 removed

comment:12 Changed 15 months ago by teor

Severity: Normal

Set all open tickets without a severity to "Normal"

Note: See TracTickets for help on using tickets.