Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#16698 closed defect (implemented)

Split directory_handle_command_get into per-command functions

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 028-triaged, tor-tests-coverage, tor-tests-unit, TorCoreTeam201605, review-group-1
Cc: Actual Points:
Parent ID: Points: 2
Reviewer: dgoulet Sponsor: SponsorS-can

Description


Child Tickets

Change History (17)

comment:1 Changed 4 years ago by nickm

Owner: set to nickm
Status: newassigned

I'm checkpointing a janky version of this as ticket16698

comment:2 Changed 4 years ago by nickm

Milestone: Tor: 0.2.7.x-finalTor: 0.2.8.x-final

comment:3 Changed 4 years ago by nickm

Keywords: 028-triaged added

comment:4 Changed 4 years ago by nickm

Keywords: SponsorS removed
Sponsor: SponsorS

Bulk-replace SponsorS keyword with SponsorS sponsor field in Tor component.

comment:5 Changed 4 years ago by nickm

Points: small/medium

comment:6 Changed 3 years ago by nickm

Severity: Normal
Status: assignedneeds_revision

comment:7 Changed 3 years ago by nickm

Milestone: Tor: 0.2.8.x-finalTor: 0.2.9.x-final

These seem like features, or like other stuff unlikely to be possible this month. Bumping them to 0.2.9

comment:8 Changed 3 years ago by isabela

Sponsor: SponsorSSponsorS-can

comment:9 Changed 3 years ago by nickm

This is in needs-revision because it's a little janky, but I'd like comment on the approach.

comment:10 Changed 3 years ago by nickm

Keywords: tor-tests-coverage tor-tests-unit added

comment:11 Changed 3 years ago by nickm

Keywords: TorCoreTeam201605 added

Give myself a few items for May. I hope I can do even more than this, but let's be careful.

comment:12 Changed 3 years ago by nickm

Status: needs_revisionneeds_review

Now please see ticket16698_v2. The tests pass, and it has comments now.

comment:13 Changed 3 years ago by nickm

Keywords: review-group-1 added

comment:14 Changed 3 years ago by dgoulet

Reviewer: dgoulet

comment:15 Changed 3 years ago by dgoulet

Status: needs_reviewmerge_ready
  • Comment says the follow for directory_handle_command_get() but we do return 404 at the end if unrecognized (/* we didn't recognize the url */). I'm guessing this is just a comment issue here.
 * ... If the request is unrecognized, send a 400.
 * Always return 0. */

Putting this in merge_ready because the above is easy to fix thus falls under nickm.

rest lgtm! (and I'm happpppppyyyy about that change :)

comment:16 Changed 3 years ago by nickm

Resolution: implemented
Status: merge_readyclosed

Fixed up and merged!

comment:17 Changed 3 years ago by isabela

Points: small/medium2
Note: See TracTickets for help on using tickets.