Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#16707 closed defect (fixed)

Packaged fonts in Tor Browser make websites partly unreadable on OS X and Windows

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: tbb-usability, tbb-fingerprinting-fonts, TorBrowserTeam201509R
Cc: arthuredelstein, mcs, mrphs Actual Points:
Parent ID: #18097 Points:
Reviewer: Sponsor:

Description

It seems the packaged fonts make webites partly unreadable. I witnessed that with a german Tor Browser 5.0a4 on a Windows 7 box. (see the attached screenshot for the problem)

Child Tickets

Attachments (1)

windows_german_font_issue.PNG (24.5 KB) - added by gk 4 years ago.

Download all attachments as: .zip

Change History (10)

Changed 4 years ago by gk

comment:1 Changed 4 years ago by arthuredelstein

The attached image is of course our own about:tor page, which arguably needs revision because it uses absolute pixels for CSS layout, instead of layout that adapts to varying font sizes. Of course, there may be some websites that have the same problem, but I haven't run into such problems while browsing the web with the #13313 patch.

gk, did you run into any websites with this issue as well?

Another possible solution is to adjust the default font size for our bundled fonts, which are currently perhaps a little larger than the average.

Last edited 4 years ago by arthuredelstein (previous) (diff)

comment:2 in reply to:  1 Changed 4 years ago by gk

Replying to arthuredelstein:

gk, did you run into any websites with this issue as well?

No. But I have not tested that much yet either.

comment:3 in reply to:  1 Changed 4 years ago by mcs

Cc: mcs added

Replying to arthuredelstein:

The attached image is of course our own about:tor page, which arguably needs revision because it uses absolute pixels for CSS layout, instead of layout that adapts to varying font sizes.

I filed #16735 to track the about:tor issue.

comment:4 Changed 4 years ago by arthuredelstein

Cc: mrphs added
Keywords: TorBrowserTeam201509R added
Status: newneeds_review

After a lot of useful discussions we have decided to substantially expand the number of allowed system fonts for Windows and Mac. For Windows, I'm whitelisting a number of fonts that have been bundled with the OS since Windows Vista (2007). For Mac, I am whitelisting a variety of fonts that have been bundled with OS X since version 10.5 (aka Leopard, 2007).

Both sets include a variety of Latin fonts as well as system-font coverage for CJK and a number of other writing systems. This approach has the advantage that it will look mostly familiar to users, and avoids adding the large Noto CJK font, which previously added ~12 MB to the download. Another nice thing is that the default chrome fonts have been whitelisted for both OSs (Segoe UI for Windows and Lucida Grande for OS X). Because we are using system fonts, it may be possible to distinguish different versions of the OS.

Here are the patches to tor-browser.git and tor-browser-bundle.git:
https://github.com/arthuredelstein/tor-browser/commit/16707
https://github.com/arthuredelstein/tor-browser-bundle/commit/16707

These versions can be downloaded for testing:
https://people.torproject.org/~arthuredelstein/downloads/16707-builds/

comment:5 Changed 4 years ago by gk

Why are you treating ar specially but not, say, ja or ru or any other locale?

comment:6 in reply to:  5 Changed 4 years ago by arthuredelstein

Replying to gk:

Why are you treating ar specially but not, say, ja or ru or any other locale?

Arabic is a special case, where the most popular Arabic-supporting font that is sure to be enabled on OS X 10.5 and later is Arial. So it helps to make sure Arial is used if HTML specifies lang=ar.

Apart from Arabic, for each language, one of two alternatives is true:

  1. Firefox already specifies in its default prefs one of the fonts we are bundling, or
  2. We only bundle one font that supports the language, and it is automatically chosen

comment:7 Changed 4 years ago by gk

Resolution: fixed
Status: needs_reviewclosed
Summary: Packaged fonts in Tor Browser make websites partly unreadablePackaged fonts in Tor Browser make websites partly unreadable on OS X and Windows

Okay. Let's try that in the next alphas. Merged with commit 10a4658832496eba75ae0b30ee3dbb25823dd23b on master (tor-browser-bundle) and applied as commit 45666d66cbd1e51e0926e3ad14831af47aa8a44d on tor-browser-38.2.1esr-5.5-2.

I changed the summary of this ticket slightly as we are only concerned with OS X and Windows here.

comment:8 Changed 3 years ago by arthuredelstein

Parent ID: 18097

comment:9 Changed 3 years ago by arthuredelstein

Parent ID: 18097#18097
Note: See TracTickets for help on using tickets.