use ThreadsafeIsCallerChrome() instead of IsCallerChrome()

This is a spinoff from #14205 (moved). For Tor Browser 5.0, we should replace all of the calls to ThreadsafeIsCallerChrome() with IsCallerChrome() in our browser patches. See ticket:14205#comment:7 for more background info.

I will post a patch soon.

added TorBrowserTeam201508R component::applications/tor browser ff38-esr owner::mcs parent::14205 priority::medium resolution::fixed status::closed tbb-5.0 type::defect labels

Trac:
Parent: N/A to #14205 (moved)

Trac:
Keywords: tbb-5.0a deleted, tbb-5.0 added

I posted four small "fixup!" patches to this branch: https://gitweb.torproject.org/user/brade/tor-browser.git/log/?h=bug16715-01

Please review. We could also smoosh them all into one commit if that is preferred, but I assume that eventually each of these fixups will be smooshed into their corresponding (original) patch.

Trac:
Status: new to needs_review
Keywords: TorBrowserTeam201508 deleted, TorBrowserTeam201508R added

Yes, one fixup per original patch is good. I merged this branch. Thanks!

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

In the case of #4755 (closed) , Kathy's patch has already landed in mozilla-central:

https://dxr.mozilla.org/mozilla-central/rev/d6ea652c579992daa9041cc9718bb7c6abefbc91/dom/events/Event.cpp#889

Should we attempt to merge this fix? Is there a situation where an Event object can be accessed from outside the main thread?

Replying to arthuredelstein:

In the case of #4755 (closed) , Kathy's patch has already landed in mozilla-central:

https://dxr.mozilla.org/mozilla-central/rev/d6ea652c579992daa9041cc9718bb7c6abefbc91/dom/events/Event.cpp#889

Should we attempt to merge this fix?

I would say "yes" unless the Mozilla engineers say that ThreadsafeIsCallerChrome() is not needed.

Is there a situation where an Event object can be accessed from outside the main thread?

I don't know.

closed

moved to tpo/applications/tor-browser#16715 (closed)