Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#16715 closed defect (fixed)

use ThreadsafeIsCallerChrome() instead of IsCallerChrome()

Reported by: mcs Owned by: mcs
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: ff38-esr, tbb-5.0, TorBrowserTeam201508R
Cc: arthuredelstein, brade, gk, mikeperry Actual Points:
Parent ID: #14205 Points:
Reviewer: Sponsor:

Description

This is a spinoff from #14205. For Tor Browser 5.0, we should replace all of the calls to ThreadsafeIsCallerChrome() with IsCallerChrome() in our browser patches. See ticket:14205#comment:7 for more background info.

I will post a patch soon.

Child Tickets

Change History (6)

comment:1 Changed 3 years ago by mcs

Parent ID: #14205

comment:2 Changed 3 years ago by mcs

Keywords: tbb-5.0 added; tbb-5.0a removed

comment:3 Changed 3 years ago by mcs

Keywords: TorBrowserTeam201508R added; TorBrowserTeam201508 removed
Status: newneeds_review

I posted four small "fixup!" patches to this branch:
https://gitweb.torproject.org/user/brade/tor-browser.git/log/?h=bug16715-01

Please review. We could also smoosh them all into one commit if that is preferred, but I assume that eventually each of these fixups will be smooshed into their corresponding (original) patch.

comment:4 Changed 3 years ago by mikeperry

Resolution: fixed
Status: needs_reviewclosed

Yes, one fixup per original patch is good. I merged this branch. Thanks!

comment:5 Changed 3 years ago by arthuredelstein

In the case of #4755 , Kathy's patch has already landed in mozilla-central:

https://dxr.mozilla.org/mozilla-central/rev/d6ea652c579992daa9041cc9718bb7c6abefbc91/dom/events/Event.cpp#889

Should we attempt to merge this fix? Is there a situation where an Event object can be accessed from outside the main thread?

comment:6 in reply to:  5 Changed 3 years ago by mcs

Replying to arthuredelstein:

In the case of #4755 , Kathy's patch has already landed in mozilla-central:

https://dxr.mozilla.org/mozilla-central/rev/d6ea652c579992daa9041cc9718bb7c6abefbc91/dom/events/Event.cpp#889

Should we attempt to merge this fix?

I would say "yes" unless the Mozilla engineers say that ThreadsafeIsCallerChrome() is not needed.

Is there a situation where an Event object can be accessed from outside the main thread?

I don't know.

Note: See TracTickets for help on using tickets.