NoScript alters whitelist on updates

Noscript sometimes alters its whitelist during updates unless the pref noscript.allowWhitelistUpdates is set to false.

We need to set this pref to false, and add logic to Torbutton to clean out the default whitelist on upgrade to 5.0.

added TorBrowserTeam201508R component::applications/tor browser owner::gk priority::medium resolution::fixed status::closed tbb-5.0 type::defect labels

Trac:
Status: new to assigned
Owner: tbb-team to gk

Ok, https://gitweb.torproject.org/mikeperry/torbutton.git/commit/?h=bug16730 has a fix for this. I tested it, and the NoScript whitelist does get cleared properly.

I also attempted a fix for #16722 (moved) here, too, but the browser completely ignored the pref update, even after a restart!

Trac:
Keywords: TorBrowserTeam201508 deleted, TorBrowserTeam201508R added
Status: assigned to needs_review

FWIW the whitelist is not completly reset to the value we want to have. There is a NoScript internal mapping that results in a user pref even if the whitelist gets cleared after an update to 5.0a4.

The main goal was that the added googleapi domains got removed. I realized that the whitelist in noscript is still differing from our default prefs, but the differences are mostly just added redundancies. I am saving #15514 (moved) for cleaning this up, and will probably use the #16730 (moved) function, but with a new increment on that version counter.

Does that sound OK? Or did you actually see other domains get added back in to the whitelist?

Yeah, sounds good. And, no, I just saw the NoScript internal stuff. Thus, we are done here with commit 15abca4ad73aab6db7213c105888ecd079b3f8fe I think

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

mentioned in issue #16783 (moved)

moved to tpo/applications/tor-browser#16730 (closed)

mentioned in issue tpo/applications/tor-browser#16783 (closed)