about:tor should accommodate different fonts/font sizes

The about:tor page, which was contributed a long time ago (see #7494 (closed)), uses some absolutely positioned elements. This causes the page to not layout well if fonts, font metrics, or font sizes are changed. We should fix it.

This came up recently; see ticket:16707#comment:1

added TorBrowserTeam201510R component::applications/tor browser owner::tbb-team priority::medium resolution::fixed severity::normal status::closed tbb-torbutton tbb-usability type::defect labels

I talked to Jeremy Todaro a while ago, who said "Also the TBB start page layout was botched somewhere between my initial design and incorporating into TBB code."

So he might be excited to help make it more like his original vision!

Replying to arma:

I talked to Jeremy Todaro a while ago, who said "Also the TBB start page layout was botched somewhere between my initial design and incorporating into TBB code."

So he might be excited to help make it more like his original vision!

I do not remember the details but I don't think we intentionally modified the layout. We did make the text localizable and we added the arrow that points to the Torbutton onion toolbar icon when TB is out of date.

How do we contact Jeremy? It would be great to have his help and it would be best if he started with the xhtml and CSS that is currently in Torbutton.

Trac:
Cc: arthuredelstein, brade, gk to arma, arthuredelstein, brade, gk

I assume this is why the layout is absolutely messed up in my ja_JP snapshot build.

Trac:

Replying to yawning:

I assume this is why the layout is absolutely messed up in my ja_JP snapshot build.

Yes. The about:tor page does not handle much variance in font sizes, text length, etc. due to use of absolutely positioned HTML elements.

Here is a fix; please review: https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug16735-01&id=08728b3bfac14fe5a325fe94cc9e7d6fe106b559 We eliminated the hard-coded heights, which makes everything work a lot better with different fonts and translations.

I suggest we try this fix in the alpha channel first.

Trac:
Status: new to needs_review
Keywords: N/A deleted, TorBrowserTeam201509R added

Ok looks fine. Pushed for 5.5a3.

Leaving open so we remember to backport after 5.5a3.

Moving needs_review tickets to October 2015.

Batch modification for realz now.

Trac:
Keywords: TorBrowserTeam201509R deleted, TorBrowserTeam201510R added

This sounds useful for backporting to 1.9.3.x and no complaints showed up with respect to the alpha. Commit c6d94fb1c74b579ea442395ad15cf37bf815e2df on maint-1.9.3 has the fix.

Trac:
Resolution: N/A to fixed
Severity: N/A to Normal
Sponsor: N/A to N/A
Status: needs_review to closed

closed

mentioned in issue #17108 (moved)

mentioned in issue #17250 (moved)

moved to tpo/applications/tor-browser#16735 (closed)