Opened 4 years ago

Closed 4 years ago

#16735 closed defect (fixed)

about:tor should accommodate different fonts/font sizes

Reported by: mcs Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-torbutton, tbb-usability, TorBrowserTeam201510R
Cc: arma, arthuredelstein, brade, gk Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The about:tor page, which was contributed a long time ago (see #7494), uses some absolutely positioned elements. This causes the page to not layout well if fonts, font metrics, or font sizes are changed. We should fix it.

This came up recently; see ticket:16707#comment:1

Child Tickets

Attachments (1)

tor-browser-5.5a2j.png (171.2 KB) - added by yawning 4 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 4 years ago by arma

I talked to Jeremy Todaro a while ago, who said "Also the TBB start page layout was botched somewhere between my initial design and incorporating into TBB code."

So he might be excited to help make it more like his original vision!

comment:2 in reply to:  1 Changed 4 years ago by mcs

Replying to arma:

I talked to Jeremy Todaro a while ago, who said "Also the TBB start page layout was botched somewhere between my initial design and incorporating into TBB code."

So he might be excited to help make it more like his original vision!

I do not remember the details but I don't think we intentionally modified the layout. We did make the text localizable and we added the arrow that points to the Torbutton onion toolbar icon when TB is out of date.

How do we contact Jeremy? It would be great to have his help and it would be best if he started with the xhtml and CSS that is currently in Torbutton.

comment:3 Changed 4 years ago by mcs

Cc: arma added

comment:4 Changed 4 years ago by yawning

I assume this is why the layout is absolutely messed up in my ja_JP snapshot build.

Changed 4 years ago by yawning

Attachment: tor-browser-5.5a2j.png added

comment:5 in reply to:  4 Changed 4 years ago by mcs

Replying to yawning:

I assume this is why the layout is absolutely messed up in my ja_JP snapshot build.

Yes. The about:tor page does not handle much variance in font sizes, text length, etc. due to use of absolutely positioned HTML elements.

comment:6 Changed 4 years ago by mcs

Keywords: TorBrowserTeam201509R added
Status: newneeds_review

Here is a fix; please review:
https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug16735-01&id=08728b3bfac14fe5a325fe94cc9e7d6fe106b559
We eliminated the hard-coded heights, which makes everything work a lot better with different fonts and translations.

I suggest we try this fix in the alpha channel first.

comment:7 Changed 4 years ago by mikeperry

Ok looks fine. Pushed for 5.5a3.

Leaving open so we remember to backport after 5.5a3.

comment:8 Changed 4 years ago by gk

Moving needs_review tickets to October 2015.

comment:9 Changed 4 years ago by gk

Keywords: TorBrowserTeam201510R added; TorBrowserTeam201509R removed

Batch modification for realz now.

comment:10 Changed 4 years ago by gk

Resolution: fixed
Severity: Normal
Status: needs_reviewclosed

This sounds useful for backporting to 1.9.3.x and no complaints showed up with respect to the alpha. Commit c6d94fb1c74b579ea442395ad15cf37bf815e2df on maint-1.9.3 has the fix.

Note: See TracTickets for help on using tickets.