Opened 9 years ago

Closed 9 years ago

#1675 closed defect (fixed)

<link href> URLs not rewritten

Reported by: schoen Owned by: pde
Priority: Medium Milestone:
Component: HTTPS Everywhere/EFF-HTTPS Everywhere Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Another kind of URL that doesn't get rewritten is one mentioned in a <link> tag.

(This is kind of similar to the prefetch issue because prefetches are indicated with <link> tags too.)

An example, from https://twitter.com/twittersearch, is

<link href="http://a1.twimg.com/a/1278529908/images/favicon.ico" rel="shortcut icon" type="image/x-icon" />
<link href="http://a1.twimg.com/a/1278529908/images/twitter_57.png" rel="apple-touch-icon" />

Even if a rule affects those URLs, they don't get rewritten, and they appear to create a mixed content warning. I'm not sure whether they get loaded, or simply ignored (I haven't checked with Wireshark).

Child Tickets

Change History (4)

comment:1 Changed 9 years ago by pde

This is actually the favicon bug, I think.

comment:2 Changed 9 years ago by pde

Seth, can you see if this is fixed in 0.3.0.development.1?

comment:3 Changed 9 years ago by schoen

It is fixed in 0.3.0.development.1. Nice work!

I made a page that included the line

<link href="http://a1.twimg.com/a/1278529908/images/favicon.ico" rel="shortcut icon" type="image/x-icon" />

Testing showed that the Twitter favicon appeared in the address bar but the favicon.ico was (correctly) loaded over HTTPS from Amazon S3.

Now Giorgio Maone is the true "Defender of the Favicon"!

comment:4 Changed 9 years ago by pde

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.