Opened 5 years ago

Closed 5 years ago

#16762 closed enhancement (implemented)

Move most of directory_all_unreachable into a backend callback

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.7.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: sponsorS, blob, TorCoreTeam201508
Cc: Actual Points:
Parent ID: #16764 Points:
Reviewer: Sponsor:


After my patch on #16695, the blob becomes smaller, but still quite scary (311 functions in our biggest SCC). If we move the body of directory_all_unreachable into a callback, we can chop that by nearly half.

Child Tickets

Change History (5)

comment:1 Changed 5 years ago by nickm

Status: newneeds_review

ticket16762 for your consideration.

comment:2 Changed 5 years ago by nickm

(I've confirmed that it removes a further 160 functions from the blob, cutting it by more than half.)

comment:3 Changed 5 years ago by nickm

Parent ID: #16764

comment:4 Changed 5 years ago by teor

I wonder if we need to check return values on tor_event_new and event_active.
Otherwise, this patch looks good - more patches like this!

comment:5 Changed 5 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Thanks! Tweaked, squashed, and merged!

Note: See TracTickets for help on using tickets.